[PR] Change default node label stacking dimension for Direction.UNDEFINED #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y when in the same cell
|
The underlying issue is that undefined values are unfortunate, something that #10 already tracks. But yes, until that is solved this seems sensible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, due to the way
Direction#isHorizontal()andDirection#isVertically()are implemented (simply ignoringUNDEFINED), an undefined layout direction resulted in a horizontal stacking of labels: left-to-right.As I feel vertically stacking is the more natural choice, I changed the behavior for undefined.
Note that for layered the direction is always right (internally during node label placement). For other layouters it can happen though that the direction is undefined as they do not support the option at all.
That being said, I tend to suggest to use a different layout option to decide on the stacking dimension than the layout direction.