Skip to content

rectpacking: Fix error in rectangle absorption. #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

rectpacking: Fix error in rectangle absorption. #1155

merged 1 commit into from
Jul 22, 2025

Conversation

soerendomroes
Copy link
Contributor

Fixes #1077

@soerendomroes soerendomroes added this to the Release 0.10.1 milestone Jul 22, 2025
@soerendomroes soerendomroes requested a review from Eddykasp July 22, 2025 07:19
@soerendomroes soerendomroes added the alg-rectpacking Affects the ELK RectPacking algorithm. label Jul 22, 2025
Eddykasp
Eddykasp approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@Eddykasp Eddykasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@soerendomroes soerendomroes merged commit 28e5173 into eclipse-elk:master Jul 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eddykasp Eddykasp Eddykasp approved these changes

Assignees
No one assigned
Labels
alg-rectpacking Affects the ELK RectPacking algorithm.
Projects
None yet
Milestone
Release 0.11.0
Development

Successfully merging this pull request may close these issues.

Rectpacking does not preserve row dominant elements
2 participants
@soerendomroes @Eddykasp