Add the fixed integer size approximator #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approximator uses multiple fixed sizes to set sizes for top-down layout according to the number of nodes in a graph. It also lays out two hierarchy levels in one step to keep them at the same scale. The LAYOUT_NEXT_LEVEL approximator lays out the given graph and sets its algorithm to fixed layout. This allows laying out multiple hierarchy levels in one pass to essentially combine bottom-up and top-down layout. A new interface ITopdownLayoutApproximator is introduced allowing size approximators to be defined for specific layout algorithms.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new fixed integer size approximator for top-down graph layouts while enhancing the interface and configuration options for size approximation. Key changes include:
- The addition of TopdownSizeApproximatorUtil containing utility methods for computing size multipliers.
- An extension of the TopdownSizeApproximator enum with a new FIXED_INTEGER_RATIO_BOXES constant and updates to the LAYOUT_NEXT_LEVEL approximator.
- The creation of the ITopdownSizeApproximator interface along with configuration changes in Core.melk and adjustments in RecursiveGraphLayoutEngine.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/options/TopdownSizeApproximatorUtil.java | New utility class for size category multiplier computations. |
| plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/options/TopdownSizeApproximator.java | Extended enum with FIXED_INTEGER_RATIO_BOXES and updated LAYOUT_NEXT_LEVEL logic. |
| plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/options/ITopdownSizeApproximator.java | New interface for top-down size approximators. |
| plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/RecursiveGraphLayoutEngine.java | Updated condition for invoking the approximator on nodes with children. |
| plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/Core.melk | Updated configuration option type for the size approximator. |
soerendomroes
approved these changes
May 21, 2025
plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/options/TopdownSizeApproximatorUtil.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approximator uses multiple fixed sizes to set sizes for top-down layout according to the number of nodes in a graph. It also lays out two hierarchy levels in one step to keep them at the same scale.
The LAYOUT_NEXT_LEVEL approximator lays out the given graph and sets its algorithm to fixed layout. This allows laying out multiple hierarchy levels in one pass to essentially combine bottom-up and top-down layout.
A new interface ITopdownLayoutApproximator is introduced allowing size approximators to be defined for specific layout algorithms.