-
-
Notifications
You must be signed in to change notification settings - Fork 32
Rework controller and autorization flow #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes eXist-db#164 - add login page as static HTML (adapted from dashboard) - rewrite controller to always authenticate requests - add routes handling new flow - add background SVG for login page
TIL that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great thank @line-o
I have checked out this branch and built and installed it into eXist 6.2.0. I can confirm that setting guest=no in eXide's configuration.xml file to cause any request to eXide to redirect to http://localhost:8080/exist/apps/eXide/login.html - with the page appearing as shown in the screenshots above. When guest=yes (as it is by default), this PR does not alter eXide's login UI at all. @line-o Is this intentional, or was the new login screen meant to replace the original login UI too? One suggestion. The placeholder for the user input field |
@joewiz thank you for taking the time to review my PR.
Yes, when guest access is restricted it is unsafe to even show the eXide page. If you are logged in and this can see eXide the form will still work and allow to switch to a different user. Nothing changes for instances where guest access is allowed.
I will change the placeholders as you suggested. |
Fixes #164
Here is a screenshot of Safari (top left), Edge (top right), Chrome (bottom left), Firefox (bottom right) showing the login page.