Skip to content

Warn user when saving contents of XQuery window with non-.xq* file extension #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2022
Merged

Warn user when saving contents of XQuery window with non-.xq* file extension #462

merged 6 commits into from
May 9, 2022

Conversation

marmoure
Copy link
Contributor

@marmoure marmoure commented May 5, 2022 •
edited by joewiz
Loading

Fixes #126.

warns user when trying to save contents of XQuery window with non-.xq* file extension and prevents it
suggests to use a new file if content is non-xquery

image

This open source contribution to the eXide project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov.

joewiz
joewiz reviewed May 6, 2022
View reviewed changes
@marmoure marmoure requested a review from joewiz May 6, 2022 14:29
joewiz
joewiz approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marmoure This works perfectly for me in both contexts: save and save as. Thank you!

dizzzz
dizzzz reviewed May 9, 2022
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

adamretter
adamretter approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joewiz joewiz merged commit c00b5e5 into eXist-db:develop May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizzzz dizzzz dizzzz left review comments

@joewiz joewiz joewiz approved these changes

+1 more reviewer

@adamretter adamretter adamretter approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn user when saving contents of XQuery window with non-.xq* file extension
4 participants
@marmoure @joewiz @adamretter @dizzzz