IBX-828:Moved unit tests to Github Actions #155
Conversation
|
Previously closed by mistake. |
c4e68d0 to
20105ea
Compare
|
Same as in ezsystems/BehatBundle#217 (comment), we need to find out why the Actions are not running |
There was a problem hiding this comment.
The PHP 7.4 job fails with:
Problem 1
- Root composer.json requires phpspec/phpspec ^5.1.2 -> satisfiable by phpspec/phpspec[5.1.2].
- phpspec/phpspec 5.1.2 requires php ^7.1, <7.4 -> your php version (7.4.24) does not satisfy that requirement.
Problem 2
- phpspec/phpspec 5.1.2 requires php ^7.1, <7.4 -> your php version (7.4.24) does not satisfy that requirement.
- memio/spec-gen 0.9.0 requires phpspec/phpspec ^5.0@rc -> satisfiable by phpspec/phpspec[5.1.2].
- Root composer.json requires memio/spec-gen ^0.9.0 -> satisfiable by memio/spec-gen[0.9.0].
Can we try to update PHPSpec so that it's possible to install it on PHP 7.4?
You'd need to:
- Change current requirement (https://github.com/ezsystems/ezplatform-http-cache/blob/1.0/composer.json#L21) to
"^5.1.2 || ^6.1" - Change the
"memio/spec-gen": "^0.9.0",requirement to"^0.9.0 || ^0.10.0"
If it's not possible we will need to drop tests on PHP 7.4
|
EDIT: It's not even present on |
|
Yes, we can try removing it as well - then we need to also remove it from the phpspec config: https://github.com/ezsystems/ezplatform-http-cache/blob/1.0/phpspec.yml#L1-L2 |
phpspec.yml
Outdated
|
|
||
| suites: |
There was a problem hiding this comment.
| suites: | |
| suites: |
No need for empty line at the beginning of the file
|
Kudos, SonarCloud Quality Gate passed!
|
TODO:
$ composer test)$ composer fix-cs).