RendererFoundation refactor #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on't need to link against DX11 or Vulkan and can change the renderer via command line
C-Core
commented
Dec 27, 2020
Code/Engine/GameEngine/GameApplication/Implementation/GameApplicationInit.cpp
Outdated
Show resolved
Hide resolved
jankrassnigg
approved these changes
Dec 30, 2020
C-Core
commented
Jan 8, 2021
| @@ -222,7 +222,7 @@ class EZ_FOUNDATION_DLL ezCommandLineOptionString : public ezCommandLineOptionDo | |||
| ezCommandLineOptionString(const char* szSortingGroup, const char* szArgument, const char* szLongDesc, const char* szDefaultValue, bool bCaseSensitive = false); | |||
|
|
|||
| /// \brief Returns the value of this option. Either what was specified on the command line, or the default value. | |||
| ezString GetOptionValue(LogMode logMode, const ezCommandLineUtils* pUtils = ezCommandLineUtils::GetGlobalInstance()) const; // [tested] | |||
| const char* GetOptionValue(LogMode logMode, const ezCommandLineUtils* pUtils = ezCommandLineUtils::GetGlobalInstance()) const; // [tested] | |||
There was a problem hiding this comment.
@jankrassnigg I changed the return value to const char* because you can easily end up with garbage strings if you return an ezString by value but the user assign it to a const char* then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added concept of passes and command encoder to renderer foundation
Also added a factory for device creation. This allows us to switch between renderer implementations via command line argument e.g. "-renderer DX11" or "-renderer Vulkan".