This repository was archived by the owner on Aug 1, 2024. It is now read-only.
add config option to disable location section #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaahc
suggested changes
Mar 17, 2022
ce30a66 to
3b89e70
Compare
yaahc
approved these changes
Mar 17, 2022
|
hmm, that failure is annoying. Can fix with a cfg on the test file I think |
15a580b to
6fdb4d5
Compare
8826bf8 to
7e62261
Compare
|
fixed the build error, remembered I had this pr and figured I'd fix it while on the phone, using dev.github.com seems promising, but it's not too great 😅 |
7e62261 to
9cbcd93
Compare
|
I'm sorry for leaving this sitting around for so long. I'll go back and fix the new clippy warnings in a followup, thank you again for the PR! |
|
No worries! I know you're busy :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #105
I'm not sure how to handle the panic hook.
I think it makes sense to always display the location even if we've set the config to false.
If this is unexpected (I think it isn't), it should be possible to implement by adding a field to
DefaultPanicMessage