feat: add CompiledPlugin #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhelx
reviewed
Nov 11, 2024
| /** | ||
| * Create a new plugin from an `ExtismCompiledPlugin` | ||
| */ | ||
| ExtismPlugin *extism_plugin_new_from_compiled(const ExtismCompiledPlugin *compiled, char **errmsg); |
There was a problem hiding this comment.
Something i still can't quite tell from this. Is there any way to point this at native code on disk somehow? My concern is someone writes some code that takes native code off disk and runs it. and somehow some user input can manipulate that. Are we protecting from that at all?
There was a problem hiding this comment.
This still doesn't open up the ability to run native code. It pretty much just splits out the linking into two steps to allow the pre-instance to be instantiated multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.