Skip to content

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Oct 28, 2024

No description provided.

@bhelx bhelx self-requested a review October 29, 2024 14:25
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see it's such a simple upgrade. Curious if we know the performance implications of this.

wasmtime = ">= 20.0.0, < 24.0.0"
wasi-common = ">= 20.0.0, < 24.0.0"
wiggle = ">= 20.0.0, < 24.0.0"
wasmtime = {version = ">= 26.0.0, < 27.0.0"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pretty tight range. curious if there are any implications to only supporting this one version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's tricky - I would be open to letting this sit until the next wasmtime release so we can support at least 2 versions but also don't want to fall too far behind. But I'm definitely not in a rush to merge this right now.

I'm not sure it's an issue for most applications to only have one supported version since I think we are the ones pulling in the wasmtime dependency is most cases. But there could be some projects out there that depend on a specific wasmtime version too.

@zshipko
Copy link
Contributor Author

zshipko commented Nov 7, 2024

Looks like there are some minor vulnerabilities in wasmtime v23 according to https://github.com/extism/extism/security/dependabot/15 - I think it's worth merging this now and hopefully we can expand the bounds from there as new wasmtime releases are made.

@zshipko zshipko merged commit af67a69 into main Nov 7, 2024
5 checks passed
@zshipko zshipko deleted the wasmtime-26 branch November 7, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants