fix(plugin_call): set rc to EXIT_SIGNALED_SIGABRT when wasmtime bails out on plugin call #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… out on plugin_call
zshipko
previously approved these changes
Oct 9, 2024
| } else if let Err(e) = &res { | ||
| if e.is::<wasmtime::Trap>() { | ||
| rc = 134; // EXIT_SIGNALED_SIGABRT | ||
| } |
There was a problem hiding this comment.
I wonder if we should do something like:
Suggested change
| } | |
| } else if rc == 0 { | |
| rc = -1; | |
| } |
in case it's possible for there to be another case where an error is returned but rc == 0. But maybe that's not needed.
There was a problem hiding this comment.
In bf95d06 I reworked it to default to -1 and avoid hiding errors that can happen first. Extism errors can happen before wasmtime errors, which happen before retrieving output errors.
zshipko
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #775
134/EXIT_SIGNALED_SIGABRT was chosen as the wasmtime CLI exits with it executes
unreachable.If it would be preferable, I could make the modification just to
extism_plugin_call_with_host_contextinstead.