feat(runtime): add log level set/get for pdk control #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@zshipko thank you for the follow up commit. I am doing a quick spike on the Go SDK implementation to see if there is any complexity as far as consistency to this impl goes. Will update here and we can merge this after that. |
|
Ok, there's a tiny bit of complexity 😆, but no more than to be expected... LGTM! |
zshipko
approved these changes
Aug 28, 2024
This was referenced Aug 30, 2024
nilslice
added a commit
to extism/go-sdk
that referenced
this pull request
Sep 16, 2024
#74) This PR aligns the extism host env with Rust, as per extism/extism#758 NOTE of breaking change: I've removed the ability to set the log level on the `*Plugin` itself. To align with Rust SDK, this is only an SDK-global setting. You can still add a custom logger to each plugin function. The SDK won't print any logs unless there is a log function set for each plugin. The global setting is in line with how libraries are expected to respect the main application's log level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to this change, @zshipko is looking into if we need to extract basic log level info from the more complex
filterstring, and how to requiretracingcompatibility to at least set some level (or to work when there is no level set thus ignoring all logs)For other runtimes, there is still an equivalent implementation for
get_log_level() -> I32in Go and JS, as well as the ability to set the log level for the host, which is then loaded whenget_log_levelis called.TODO: