Skip to content

fix: check return value of os.MkdirAll #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

fix: check return value of os.MkdirAll #113

merged 1 commit into from
Jul 23, 2025

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Jul 23, 2025 •
edited
Loading

Fixes #112

Before when ran without sudo, extism lib install ignored errors when creating directories:

patrick@Mac local % extism lib install
Installing v1.12.0 to /usr/local
Fetching https://github.com/extism/extism/releases/download/v1.12.0/libextism-aarch64-apple-darwin-v1.12.0.tar.gz
Error: open /usr/local/include/extism.h: no such file or directory

Now:

gavin@Gavins-MacBook-Pro cli % go run extism/main.go lib install 
Installing v1.12.0 to /usr/local
Fetching https://github.com/extism/extism/releases/download/v1.12.0/libextism-aarch64-apple-darwin-v1.12.0.tar.gz
Error: mkdir /usr/local/include: permission denied

@G4Vi G4Vi requested review from zshipko and nilslice as code owners July 23, 2025 15:36
@G4Vi G4Vi merged commit ad81e44 into main Jul 23, 2025
7 checks passed
@G4Vi G4Vi deleted the gavin/20250723-mkdir-error-checking branch July 23, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice Awaiting requested review from nilslice nilslice is a code owner

1 more reviewer

@zshipko zshipko zshipko approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extism lib install fails on macOS due to missing /usr/local/include /usr/local/lib folders
2 participants
@G4Vi @zshipko