Update for python 3.10+: branch on SelectableGroups #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Branch on presence of `SelectableGroups` when retrieving entry points - Branch on python version in tests when creating dummy entry points
|
This still needs some more testing beyond the test suite... |
|
I've tested this with thinc and spacy with a range of python versions including python 3.11.0b4 without running into any problems. |
3 tasks
rmitsch
reviewed
Jul 15, 2022
adrianeboyd
commented
Jul 26, 2022
adrianeboyd
commented
Jul 26, 2022
ines
approved these changes
Jul 26, 2022
adrianeboyd
added a commit
to adrianeboyd/catalogue
that referenced
this pull request
Oct 4, 2022
adrianeboyd
added a commit
to adrianeboyd/catalogue
that referenced
this pull request
Oct 4, 2022
adrianeboyd
added a commit
to adrianeboyd/catalogue
that referenced
this pull request
Oct 4, 2022
adrianeboyd
added a commit
that referenced
this pull request
Oct 7, 2022
* Move catalogue.py to module dir * Update setup * Add vendored importlib_metadata v3.2.0 * Move tests into package * Backport changes from #41 * Check for select rather than to-be-deprecated SelectableGroups * Set version to v1.0.1, update classifiers * Update CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectableGroupswhen retrieving entry points