Skip to content

fix(bundler): Device filtering in SDK 53 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 10, 2025
Merged

fix(bundler): Device filtering in SDK 53 #272

merged 5 commits into from
Jul 10, 2025

Conversation

krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Jun 18, 2025 •
edited
Loading

Linked issue

Provide the issue(s) which this pull request relates to or fixes.

Additional context

Are there things the maintainers should be aware of before merging or closing this pull request?

This PR fixes:

  • Version misalignment in the lock file
  • Expo Go filtering test
  • Expo Go filtering after expo/expo@f545f30
  • Filter Reanimated UI Inspectable target
Details

Filter out Reanimated UI runtime

  {
    "id": "027caaae50b565d3dcf71a35ae72343af5381b76-1",
    "title": "com.krystofwoldrich.ToTheMoon (iPhone 16)",
    "description": "React Native Bridgeless [C++ connection]",
    "appId": "com.krystofwoldrich.ToTheMoon",
    "type": "node",
    "devtoolsFrontendUrl": "devtools://devtools/bundled/js_app.html?experiments=true&v8only=true&ws=localhost%3A8081%2Finspector%2Fdebug%3Fdevice%3D027caaae50b565d3dcf71a35ae72343af5381b76%26page%3D1",
    "webSocketDebuggerUrl": "ws://localhost:8081/inspector/debug?device=027caaae50b565d3dcf71a35ae72343af5381b76&page=1",
    "deviceName": "iPhone 16",
    "reactNative": {
      "logicalDeviceId": "027caaae50b565d3dcf71a35ae72343af5381b76",
      "capabilities": {
        "prefersFuseboxFrontend": true,
        "nativeSourceCodeFetching": false,
        "nativePageReloads": true
      }
    }
  },
  {
    "id": "027caaae50b565d3dcf71a35ae72343af5381b76-2",
    "title": "com.krystofwoldrich.ToTheMoon (iPhone 16)",
    "description": "Reanimated UI runtime [C++ connection]",
    "appId": "com.krystofwoldrich.ToTheMoon",
    "type": "node",
    "devtoolsFrontendUrl": "devtools://devtools/bundled/js_app.html?experiments=true&v8only=true&ws=localhost%3A8081%2Finspector%2Fdebug%3Fdevice%3D027caaae50b565d3dcf71a35ae72343af5381b76%26page%3D2",
    "webSocketDebuggerUrl": "ws://localhost:8081/inspector/debug?device=027caaae50b565d3dcf71a35ae72343af5381b76&page=2",
    "deviceName": "iPhone 16",
    "reactNative": {
      "logicalDeviceId": "027caaae50b565d3dcf71a35ae72343af5381b76",
      "capabilities": {
        "prefersFuseboxFrontend": false,
        "nativeSourceCodeFetching": false,
        "nativePageReloads": false
      }
    }
  }

PS.: I'm still having issues with the debugger (missing source maps) after these fixes, but I think that should be solved in different PR. After this PR the plugging connects VSCode to the correct target and the console logs are printed as expected.

@krystofwoldrich krystofwoldrich marked this pull request as draft June 18, 2025 09:24
@krystofwoldrich krystofwoldrich changed the title fix(bundler): Device filtering of Expo Go in SDK 53 fix(bundler): Device filtering in SDK 53 Jun 18, 2025
@krystofwoldrich krystofwoldrich marked this pull request as ready for review June 18, 2025 12:13
@krystofwoldrich krystofwoldrich requested a review from byCedric July 9, 2025 22:00
@krystofwoldrich krystofwoldrich merged commit ebdc98a into expo:main Jul 10, 2025
2 of 12 checks passed
expo-bot pushed a commit that referenced this pull request Jul 10, 2025
chore: create new release 1.6.1
8053803 
## [1.6.1](1.6.0...1.6.1) (2025-07-10)

### Bug fixes

* **bundler:** Device filtering in SDK 53 ([#272](#272)) ([ebdc98a](ebdc98a))
@expo-bot
Copy link
Contributor

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric byCedric approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug Expo App Console doesn't print any logs with SDK 53
3 participants
@krystofwoldrich @expo-bot @byCedric