Skip to content

Conversation

tsapeta
Copy link
Contributor

@tsapeta tsapeta commented Feb 24, 2020

Why

Since I added native-component-list to bare-expo app (#6868), tests are sometimes failing due to timeouts. It mostly refers only to the first test suite because it's the first to trigger code bundling. Excluding native-component-list code from bare-expo when it's run on the CI should solve the problem or at least reduce code bundling time.

How

If process.env.CI or process.env.NO_NCL is truthy, then we will use custom resolver for all imports from native-component-list - the custom resolver will simply return null - so its main navigators won't be included in the bottom tabs navigator.

Test Plan

  • yarn run test:web in apps/bare-expo works locally and I see native-component-list paths in webpack's logs and the total time for Basic tests is high.
  • CI=true yarn run test:web also passes and takes significantly less time.
  • yarn run ios works as expected.
  • CI=true yarn run ios works as well, with just test-suite app included.
  • sdk/web_test_suite passes and bundling time is much better now.

@tsapeta tsapeta marked this pull request as ready for review February 24, 2020 14:39
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tsapeta tsapeta force-pushed the @tsapeta/remove-ncl-from-bare-on-ci branch from eedfa92 to 31253fb Compare February 25, 2020 12:12
@tsapeta tsapeta merged commit cd88970 into master Feb 25, 2020
@tsapeta tsapeta deleted the @tsapeta/remove-ncl-from-bare-on-ci branch February 25, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants