Skip to content

Conversation

IjzerenHein
Copy link
Contributor

Why

Fix documentation for ScreenOrientation.getOrientationAsync() which returned the wrong type.
Additionally some other small errors were found in the docs and fixed.

Fixes #7706

How

Updated docs in unversioned and for sdk37.

Test Plan

Looks good to me.

Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏅
Thanks for fixing that ;)

@IjzerenHein IjzerenHein merged commit 0cb7fb6 into master Apr 7, 2020
@IjzerenHein IjzerenHein deleted the @hein/docs/screen-orientation-update branch April 7, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getOrientationAsync after upgrade to SDK37 does not return a ScreenOrientationInfo object, instead it return orientationId
2 participants