Skip to content

[android] Update ReactAndroid to bare-compatible react-native #6286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2019
Merged

[android] Update ReactAndroid to bare-compatible react-native #6286

merged 3 commits into from
Nov 18, 2019

Conversation

sjchmiela
Copy link
Contributor

Why

Fix for #6200 (comment).

How

Test Plan

Expo client compiled ok.

@sjchmiela sjchmiela requested review from brentvatne and ide November 15, 2019 15:21
@ide
Copy link
Member

ide commented Nov 16, 2019

Looks good, although I think the react-native-lab changes in expo/react-native#20 can be cleaned up further.

@sjchmiela sjchmiela force-pushed the @sjchmiela/fix_rnlab branch from eff9469 to a85c54b Compare November 18, 2019 09:52
@sjchmiela sjchmiela merged commit 2afd270 into master Nov 18, 2019
@sjchmiela sjchmiela deleted the @sjchmiela/fix_rnlab branch November 18, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ide ide ide approved these changes

@brentvatne brentvatne Awaiting requested review from brentvatne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjchmiela @ide