[auth-session] Extract AuthSession into unimodule #6989

lukmccall · 2020-02-07T10:56:46Z

Why

Resolves #6515.

How

Create a new unimodule expo-auth-session.
Remove old implementation
Remove dependency on expo-linking (it uses react native linking).
Add support to the bare workflow (users need to provide valid redirect URL and return URL).

TODO

update docs

Test Plan

🛠	Managed	Bare
NLC	✅	✅
Simple sandbox app	✅	✅

packages/expo-auth-session/package.json

packages/expo-auth-session/src/BareSessionUrlProvider.ts

packages/expo-auth-session/src/ManagedSessionUrlProvider.ts

packages/expo-auth-session/src/SessionUrlProvider.ts

packages/expo-auth-session/src/ManagedSessionUrlProvider.ts

packages/expo-auth-session/unimodule.json

esamelson

Thanks for your thorough work on this and for adding and modifying the proper tests 🙏 And thanks for making it work with self-hosting, as well! 💯

Could you add some documentation about how to use this module in the bare workflow, and what requirements there are for the backend server hosted at the authUrl that you provide? IIRC the service at https://auth.expo.io provides some nice "magic" functionality like auto-redirecting to the provided URL. Since the authUrl you provide in a bare workflow scenario will actually be used as the startUrl (rather than https://auth.expo.io with some query params) do we make any assumptions about the service at this authUrl?

Also, reading through the code I'm a little confused about how the redirectUrl is used in the bare workflow scenario and why one would need to provide it. I think docs would help clarify this.

packages/expo-auth-session/src/BareSessionUrlProvider.ts

ExpoBot · 2020-02-17T10:27:20Z

	Warnings
⚠️	You modified `sdk/auth-session.md` in the `unversioned` directory. Please consider copying the changes to the latest released version if applicable.

Generated by 🚫 dangerJS against 83161b8

lukmccall · 2020-02-17T10:34:15Z

@esamelson, I updated the documentation. I've also provided a simple proxy service implementation. I think this will make it a little bit easier to understand. Please let me know if anything is unclear.

esamelson

Thanks, looks good, let's go ahead and land this!

One other question for my own edification -- in the bare workflow case, is the proxy server necessary? Or could you in theory set up your auth service such that it redirects right back into your app?

packages/expo-auth-session/package.json

packages/expo-auth-session/README.md

docs/pages/versions/unversioned/sdk/auth-session.md

lukmccall · 2020-02-18T08:54:46Z

One other question for my own edification -- in the bare workflow case, is the proxy server necessary? Or could you in theory set up your auth service such that it redirects right back into your app?

In the bare workflow, you can skip the proxy server. The auth service can redirect right back to your app.

I made some updates to the guide for using custom fonts. Changes include: - Using Snacks for examples - Using the `useFonts` hook for a simpler example - Example of loading a remote font - Discussion of font formats Squashed commits below * [android] 🤏 Update react-native-gesture-handler to 1.6.0 (#7121) # Why Part of #7006 # How - Used `et update-vendored-module` to update `react-native-gesture-handler`. - Updated versions in some apps. - Tried to run it on Android... and it turned out there is a new `RNGHModalUtils` file scoped under `com.facebook.react` package so I've copied this file manually to appropriate directory in `expoview`. - Added a warning saying that `com.facebook.react` needs to be manually updated, we already do the same in `react-native-reanimated`. - Added changelog entry. # Test Plan Tested examples in `native-component-list`. * [constants] make installationId available in bare (#6906) * [constants] make available in bare * make filename constant * remove installationId from scoped android module * remove installationId from scoped ios * fix ios_test_suite * fix app auth code block (#7138) * fix app auth code block * Update app-auth.md * Update app-auth.md * [ios][expo-constants] remove duplicate symbol kEXDeviceInstallUUIDKey to fix iOS client build * Updated linking.md (#7136) * Updated linking.md Updated description for WebBrowser to follow latest changes. * Tidy up docs Less `const fn = () => `, function keyword is usually better Co-authored-by: James Ide <ide@users.noreply.github.com> * [android][home] 🤖 Add DevMenu on Android (#6829) # Why Fixes #6521 # How - Created unversioned `DevMenuManager` class which mostly just delegates calls to versioned `DevMenuModule` modules specific for SDK version. These modules are responsible for providing initial props, dev menu options and actions to run when these options are selected. The manager creates a new `ReactRootView` that bases on kernel's (home's) React instance manager and starts `HomeMenu` app which is registered as a second entry point in `home` and then, manager adds this root view to the currently used activity (it must implement `ExperienceActivity`). As I needed to know which experience activity is the current one, I've added `sCurrentActivity` static member to that class and just track it using activity's lifecycle methods. - Backported `DevMenuModule` to all SDK versions included in the client. Including some changes between them - for example hot and fast reloading. - Added support for back button and Android's menu press (which can be simulated by `adb shell input keyevent 82`). - Removed some unused code related to `Nux` and replaced it with new onboarding screen (see #6793). - Created new `ShakeDetector` which works more like on iOS. The one provided by React Native is annoying in most cases as it actually requires two shakes. - Updated `ReactAndroidCodeTransformer` to turn off showing React Native dev menu in non-standalone apps. - **To do after merging:** Rebuild versioned expoviews. # Test Plan - [x] Test on experience in debug mode - [x] Test on experience in production mode - [x] Test on snacks - [x] Test on older SDKs - [x] Test on simulators - [x] Test that onboarding shows up once you open the experience for the first time or you didn't accept it yet (clicked `Got it` button). - [x] Test that using dev menu still works once we kill home's activity. * [home] 🏠 Publish new dev home * [auth-session] Extract AuthSession into unimodule (#6989) * [expo-auth-session] Extract * [expo-auth-session] Remove from the expo package * [expo-auth-session] Add bare support * [expo-auth-session] Refactor * [expo-auth-session] Fix CI * [expo-auth-session] Update CHANGELOG * [expo-auth-session] Apply requested changes * [expo-auth-session] Update README * [expo-auth-session] Update documentation * [expo-auth-session] apply requested changes * [auth-session] Fix CI * run yarn * [expo-screen-orientation] Update documentation (#6838) * [expo-screen-orientation] Update docs & add checks to lockPlatfomAsync on iOS * [expo-screen-orientation] Update installation instruction * [expo-screen-orientation] Fix quotations marks * [expo-screen-orientation] Update changelog * [expo-screen-orientation] Apply requested changes * [screen-orientation] Apply requested changes * [screen-orientation] Apply requested changes * [screen-orientation] Apply requested changes * [firebase-core] Add core functionality for supporting native Firebase packages (#7013) * [bare-expo] Fix database-url in GoogleService-Info.plist * [firebase-core] Add `expo-firebase-core` package * [firebase-core] Add tests to test-suite * [firebase-core] Add scoped firebase-core to Expo client to create native sandboxed firebase apps * [firebase-core] Update bare-expo BasePackageList * [firebase-core] Add firebase-core to bundledNativeModules.json * [firebase-core] Add SDK documentation * [firebase-core] Add firebase-core to Expo client iOS project file * [firebase-core] Add js build files * [firebase-core] Update SDK doc to refer to native firebase guide * [firebase-core] Add web-support & code cleanup * [docs] Fixes to firebase-core docs * [firebase-core] Update build files * [firebase-core] Fix test in test-suite * [fireabase-core] Cleanup COMPARISON.md * [firebase-core] Improve google-services.json parsing and client selection * [firebase-core] Updated SDK docs * [fireabse-core] Update readme description * [firebase-core] Removed outcommented line on Android * [firebase-core] Minor iOS code improvements after review * [firebase-core] Fixes after review to unit tests * [firebase-core] Updated iOS code after review feedback * [firebase-core] Fix tests * [firebase-core] Simplify JS code * [firebase-core] Update js build output * [fireabse-core] Add DEFAULT_WEB_APP_OPTIONS constant + doc improvements * [firebase-core] Update JS build files * [firebase-core] Fix unimodulePeerDependencies in package.json * [firebase-core] Android build.gradle fixes * [firebase-core] Android base64 encoding code improvement * [firebase-core] Prevent hard javascript import error when native lib not linked * [firebase-core] Update various Android methods to be protected i.s.o. public * [firebase-core] Android protected DEFAULT_APP_NAME and re-use in scoped * [firebase-core] Update changelog * [fireabse-core] Update JS build files * [firebase-android] Fix Firebase App cleanup when multiple projects are loaded on Android * [ios] Update pods * [firebase-analytics] Add native Firebase Analytics (#7017) * [firebase-core] Add tests to test-suite * [fireabse-analytics] Add expo-firebase-analytics package * [firebase-core] Add firebase-core to Expo client iOS project file * [firebase-analytics] Add tests to test-suite * [bare-expo] Update iOS app-icon assets * [firebase-analytics] Add expo-firebase-analytics to Expo client * [bare-expo] Add firebase-analytics to BasePackageList.java * [firebase-analytics] Add firebase-analytics to bundleNativeModules.json * [docs] Add firebase-analytics docs * [firebase-analytics] Update yarn.lock after adding `firebase` (js sdk) dependency * [firebase-analytics] Add js build output * [firebase-analytics] Update sdk docs * [firebase-analytics] Update SDK docs * [firebase-analytics] Remove firebase JS dep to check CI * [docs] Update SDK docs & readme for expo-firebase-analytics * [expo-analytics] Remove firebase peer-dependency * [firebase-analytics] Add web-support & code cleanup * [docs] Update firebase-analytics docs * [firebase-analytics] Update build files * [firebase-analytics] Fix outdated build files * [firebase-analytics] Fix lint warnings * [firebase-analytics] Fixed code-style errors & typos after review * [firebase-analytics] Moved `unimodulePeerDependencies` to regular peerDependencies in package.json * [firebase-analytics] Update js build output * [fireabse-analytics] Update changelog * [firebse-analytics] Update Android build.gradle * [ios] Update pods * [firebase-analytics] Add recording of `screen_view` event when calling `setCurrentScreen` On web, calling `setCurrentScreen` does not automatically record a screen_view event as it does on native. We therefore record the 'screen_view' event manually. https://stackoverflow.com/questions/59330467/how-to-track-page-view-with-firebase-analytics-in-a-web-single-page-app * [firebase-analytics] Update JS build files * [firebase-analytics] Remove @unimodules/core peerDependency from package.json * [docs] Add firebase web-config to app.json docs (#7086) * [firebase-analytics] Add pure JS analytics for use on Expo Client (#7093) * [firebase-analytics] WIP js analytics * [firebase-analytics] Add Pure JS FirebaseAnalytics (wip, 80% done) * [firebase-analytics] Add pure JS Firebase Analytics (done) * [firebase-analytics] Update & integrate Pure JS Analytics tracker * [docs] Add instruction on how to use firebase analytics on Expo Client * [firebase-analytics] Fixes after review feedback * [firebase-analytics] Update JS build files * [firebase-analytics] Update analytics-js to use DEFAULT_WEB_APP_OPTIONS * [firebase-analytics] Update JS build files * [firebase-analytics] Add recording of `screen_view` events on Expo client, when calling `setCurrentScreen` This mimics the behavior on Native, when calling setCurrentScreen also records a screen-view event. Note that this is different from the Firebase JS SDK, which does not record a screen-view event, and requires `logEvent` to be called manually. * [firebase-analytics] Update JS build files * [iOS][notifications] feature: customize notification preview placeholders (#7052) * [ios] add handling for previewPlaceholder * fix on android * update docs * feedback: mark api availability * resolve conflict * Update docs/pages/versions/unversioned/sdk/notifications.md Co-Authored-By: James Ide <ide@users.noreply.github.com> * fix typo * fix ci errors for expo package Co-authored-by: James Ide <ide@users.noreply.github.com> * [camera][iOS] Reject from takePictureAsync if camera is not ready (#7144) # Why Resolves #3020 Calling [camera#takePictureAsync](https://docs.expo.io/versions/latest/sdk/camera/#takepictureasync) should reject if [camera#onCameraReady](https://docs.expo.io/versions/latest/sdk/camera/#oncameraready) callback wasn't called before (native camera isn't ready yet), while now call is silently lost and promise is neither resolved nor rejected. # How Reject from `camera.takePictureAsync` if native camera is not ready yet. # Test Plan [snack](https://snack.expo.io/@bbarthec/github---camera---ios---takepictureasync) * [android][ncl] Update @react-native-community/masked-view to 0.1.6 * [android][ios][ncl] Update @react-native-community/viewpager to 3.3.0 * [android][ios][ncl][bare-expo] Update react-native-reanimated to 1.7.0 * [android][ios][ncl] Update react-native-svg to 11.0.1 * [android][ios][ncl] Updated react-native-webview to 8.1.1 * [expo] Update react-native-view-shot to 3.1.2 * [expotools] fix update-vendored-module for react-native-appearance * [android][ncl][home] Update react-native-appearance to 0.3.2 * [android][ios][ncl][bare-expo] Update react-native-safe-area-context to 0.7.3 * [ios] fix improperly namespaced import in RNSVGForeignObject * [bare-expo] reinstall pods * [android][location] Fixed NPE crash when mTask is made null mid-process. (#7147) * Remove ANY_HOSTNAME_VERIFIER from Android app-auth debug connection builder (#7152) * Change constant declaration to static ot aviod duplication of symbols. (#7161) * [image-picker] Prevent from reloading on OnePlus 7 (#7162) # Why Resolves #5804. # How Create the output file before open the camera intent. # Test Plan - NCL ✅ - #5804 (comment) ✅ * [test-suite] Fix test-suite error on start (#7163) # Why Dismissing error screen on every refresh can be daunting after some time (when running in `bare-expo`). # How - added `try`-`catch` around calls to missing Facebook Ads module - added `if (ExpoTaskManager)` around `eventEmitter.addListener`, since event name is fetched as a constant of the module which may be `undefined` - moved `require(testScreen)` which define tasks to _initialization phase_ - moved `require(cameraScreen)` to global scope since I feel `optionalRequire` only works in global scope (and well, it let me get rid of red screen) # Test Plan Running `bare-expo` does not show error screen. * [image-picker] Remove unused header import (#7168) # Why Resolves #7167. # How Remove unused import. # Test Plan - ios build ✅ * [docs] add permissions methods to api list (#7053) * add permissions methods to api list * add requestPermissionsAsync and getPermissionsAsync methods to TOC * Suggestion in sentry guide (#7157) * Suggestion in sentry guide * identical changes to v36.0.0 docs * [android][task-manager] Task manager for bare in Expo (#6828) Task manager for bare android and iOS applications. * [docs] fix app signing page (#7171) * [docs] fix app signing page * unversioned * typo * [android] remove SDK 33 code re-committed after 38ccf62 * [docs] Update ‘using-firebase’ guide with Analytics section (#7145) * [docs] Update ‘using-firebase’ guide with Analytics section * [docs] Add missing `expo-firebase-core` dep to ‘usinig-firebase’ doc * Update docs/pages/versions/unversioned/guides/using-firebase.md Co-Authored-By: Brent Vatne <brentvatne@gmail.com> * [jest-expo-enzyme] publish 1.0.0 * Update expo-module-scripts dependency (#7175) * [docs] Custom fonts guide update Work in progress * [docs] Updating guide to using custom fonts I made some updates to the guide for using custom fonts. Changes include: - Using Snacks for examples - Using the `useFonts` hook for a simpler example - Example of loading a remote font - Discussion of font formats * Update docs/pages/versions/unversioned/guides/using-custom-fonts.md Co-Authored-By: Brent Vatne <brentvatne@gmail.com> * Update docs/pages/versions/unversioned/guides/using-custom-fonts.md Co-Authored-By: Cedric van Putten <me@bycedric.com> * Update docs/pages/versions/unversioned/guides/using-custom-fonts.md Co-Authored-By: Brent Vatne <brentvatne@gmail.com> Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com> Co-authored-by: Charlie Cruzan <35579283+cruzach@users.noreply.github.com> Co-authored-by: Evan Bacon <baconbrix@gmail.com> Co-authored-by: Eric Samelson <esamelson@users.noreply.github.com> Co-authored-by: Saumya Sharma <saumyasharma010@gmail.com> Co-authored-by: James Ide <ide@users.noreply.github.com> Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@student.uj.edu.pl> Co-authored-by: Dominik Sokal <dominiksokal@gmail.com> Co-authored-by: Hein Rutjes <IjzerenHein@users.noreply.github.com> Co-authored-by: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com> Co-authored-by: briefjudofox <1484049+briefjudofox@users.noreply.github.com> Co-authored-by: Michał Czernek <czernekmichal@gmail.com> Co-authored-by: Stanisław Chmiela <sjchmiela@users.noreply.github.com> Co-authored-by: Ziv Levy <zivl@users.noreply.github.com> Co-authored-by: Nishant Singh <saysnishant@gmail.com> Co-authored-by: Brent Vatne <brentvatne@gmail.com> Co-authored-by: Cedric van Putten <me@bycedric.com>

SimenB · 2020-04-01T05:42:15Z

packages/expo-auth-session/src/AuthSession.types.ts

@@ -0,0 +1,19 @@
+declare global {
+  // eslint-disable-next-line no-redeclare
+  const __DEV__: boolean;


can we remove this? It clashes with the declaration in @types/react-native

celandro · 2020-04-04T18:46:26Z

The website documentation needs to be updated with the new import.
import * as AuthSession from 'expo-auth-session';
I spent hours trying to resolve this.

In addition, this change was backwards compatible and should have had a yellow box warning for the upgrade process to be smooth

brentvatne · 2020-04-04T19:38:49Z

The website documentation needs to be updated with the new import.

import * as AuthSession from 'expo-auth-session';

I spent hours trying to resolve this.

In addition, this change was backwards compatible and should have had a yellow box warning for the upgrade process to be smooth

it is listed under the breaking changes in the changelog https://github.com/expo/expo/blob/master/CHANGELOG.md

good point re: updating the auth session example in the docs!

lukmccall requested review from ide and tsapeta as code owners February 7, 2020 10:56

lukmccall force-pushed the @lukmccall/expo-auth-session-extract-to-unimodule branch from 83d2f3e to 9db51c8 Compare February 12, 2020 13:51

tsapeta changed the title ~~[expo-auth-session] extract into unimodule~~ [auth-session] Extract AuthSession into unimodule Feb 13, 2020

tsapeta suggested changes Feb 13, 2020

View reviewed changes

tsapeta requested a review from esamelson February 13, 2020 18:06

esamelson reviewed Feb 13, 2020

View reviewed changes

packages/expo-auth-session/src/BareSessionUrlProvider.ts Outdated Show resolved Hide resolved

packages/expo-auth-session/src/BareSessionUrlProvider.ts Outdated Show resolved Hide resolved

lukmccall requested a review from esamelson February 17, 2020 10:34

esamelson approved these changes Feb 18, 2020

View reviewed changes

tsapeta reviewed Feb 18, 2020

View reviewed changes

lukmccall requested a review from tsapeta February 18, 2020 09:34

tsapeta approved these changes Feb 21, 2020

View reviewed changes

lukmccall added 10 commits February 21, 2020 11:21

[expo-auth-session] Extract

653d882

[expo-auth-session] Remove from the expo package

4efb4bf

[expo-auth-session] Add bare support

a863110

[expo-auth-session] Refactor

54d83b8

[expo-auth-session] Fix CI

d163f20

[expo-auth-session] Update CHANGELOG

90ce37b

[expo-auth-session] Apply requested changes

197a007

[expo-auth-session] Update README

1edc77a

[expo-auth-session] Update documentation

10006a2

[expo-auth-session] apply requested changes

295c79b

lukmccall force-pushed the @lukmccall/expo-auth-session-extract-to-unimodule branch from c3ae835 to 295c79b Compare February 21, 2020 10:32

[auth-session] Fix CI

83161b8

lukmccall merged commit f51e8f4 into master Feb 21, 2020

lukmccall deleted the @lukmccall/expo-auth-session-extract-to-unimodule branch February 21, 2020 12:26

SimenB reviewed Apr 1, 2020

View reviewed changes

[auth-session] Extract AuthSession into unimodule #6989

[auth-session] Extract AuthSession into unimodule #6989

Uh oh!

Conversation

lukmccall commented Feb 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

How

TODO

Test Plan

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

esamelson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ExpoBot commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukmccall commented Feb 17, 2020

Uh oh!

esamelson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukmccall commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimenB Apr 1, 2020

Choose a reason for hiding this comment

Uh oh!

celandro commented Apr 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brentvatne commented Apr 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lukmccall commented Feb 7, 2020 •

edited

Loading

ExpoBot commented Feb 17, 2020 •

edited

Loading

lukmccall commented Feb 18, 2020 •

edited

Loading

celandro commented Apr 4, 2020 •

edited

Loading

brentvatne commented Apr 4, 2020 •

edited

Loading