[android] Cleanup Android's buildscripts 🧹 #6987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d55c101 to
2b36ebf
Compare
ide
approved these changes
Feb 7, 2020
| @@ -17,6 +6,21 @@ apply plugin: 'maven' | |||
| group = 'host.exp.exponent' | |||
| version = '8.1.0' | |||
|
|
|||
| buildscript { | |||
There was a problem hiding this comment.
Will this create buildscript sections in new modules based on this template?
There was a problem hiding this comment.
Yes, because new modules are already being written in Kotlin (there is an implementation below) and I think we still don't want to assume that people using our modules have Kotlin configured in their projects, so until then we should have this buildscript there and download Kotlin's gradle plugin if it's not there yet. Anyway, we will use ext.kotlinVersion so users will be able to set one specific version and reduce number of downloads.
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
# Why Followup expo#6977 After some discussions in the team, we think that it's better to remove Gradle plugin from buildscripts entirely. We will still use `buildscript` in some libraries that use some custom plugins like the one for Kotlin, but in general most of Android libraries don't include `buildscript` if they don't use any other plugins. So now we assume the root project must have Gradle plugin in their own `buildscript` block. Also, we don't see any use-case to open these libs as root projects. # How - Removed unnecessary `buildscript` in `build.gradle` from all packages. - Removed `repository { mavenCentral() }` from packages that don't need that (they mostly depended on just `unimodules-core`). - Ensured Kotlin plugin version and Kotlin dependency version are in sync. - Fixed some packages not using `minSdkVersion`/`targetSdkVersion`/`compileSdkVersion` not allowing to override versions through the root project configuration. # Test Plan All checks on the CI have passed. I've built the app locally and it works as well.
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why Followup expo#6977 After some discussions in the team, we think that it's better to remove Gradle plugin from buildscripts entirely. We will still use `buildscript` in some libraries that use some custom plugins like the one for Kotlin, but in general most of Android libraries don't include `buildscript` if they don't use any other plugins. So now we assume the root project must have Gradle plugin in their own `buildscript` block. Also, we don't see any use-case to open these libs as root projects. # How - Removed unnecessary `buildscript` in `build.gradle` from all packages. - Removed `repository { mavenCentral() }` from packages that don't need that (they mostly depended on just `unimodules-core`). - Ensured Kotlin plugin version and Kotlin dependency version are in sync. - Fixed some packages not using `minSdkVersion`/`targetSdkVersion`/`compileSdkVersion` not allowing to override versions through the root project configuration. # Test Plan All checks on the CI have passed. I've built the app locally and it works as well.
gurs1kh
pushed a commit
to gurs1kh/expo
that referenced
this pull request
Jan 18, 2024
# Why Followup expo#6977 After some discussions in the team, we think that it's better to remove Gradle plugin from buildscripts entirely. We will still use `buildscript` in some libraries that use some custom plugins like the one for Kotlin, but in general most of Android libraries don't include `buildscript` if they don't use any other plugins. So now we assume the root project must have Gradle plugin in their own `buildscript` block. Also, we don't see any use-case to open these libs as root projects. # How - Removed unnecessary `buildscript` in `build.gradle` from all packages. - Removed `repository { mavenCentral() }` from packages that don't need that (they mostly depended on just `unimodules-core`). - Ensured Kotlin plugin version and Kotlin dependency version are in sync. - Fixed some packages not using `minSdkVersion`/`targetSdkVersion`/`compileSdkVersion` not allowing to override versions through the root project configuration. # Test Plan All checks on the CI have passed. I've built the app locally and it works as well.
Eric-Tyrrell22
pushed a commit
to Eric-Tyrrell22/expo
that referenced
this pull request
Aug 14, 2025
# Why Followup expo#6977 After some discussions in the team, we think that it's better to remove Gradle plugin from buildscripts entirely. We will still use `buildscript` in some libraries that use some custom plugins like the one for Kotlin, but in general most of Android libraries don't include `buildscript` if they don't use any other plugins. So now we assume the root project must have Gradle plugin in their own `buildscript` block. Also, we don't see any use-case to open these libs as root projects. # How - Removed unnecessary `buildscript` in `build.gradle` from all packages. - Removed `repository { mavenCentral() }` from packages that don't need that (they mostly depended on just `unimodules-core`). - Ensured Kotlin plugin version and Kotlin dependency version are in sync. - Fixed some packages not using `minSdkVersion`/`targetSdkVersion`/`compileSdkVersion` not allowing to override versions through the root project configuration. # Test Plan All checks on the CI have passed. I've built the app locally and it works as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Followup #6977
After some discussions in the team, we think that it's better to remove Gradle plugin from buildscripts entirely. We will still use
buildscriptin some libraries that use some custom plugins like the one for Kotlin, but in general most of Android libraries don't includebuildscriptif they don't use any other plugins. So now we assume the root project must have Gradle plugin in their ownbuildscriptblock. Also, we don't see any use-case to open these libs as root projects.How
buildscriptinbuild.gradlefrom all packages.repository { mavenCentral() }from packages that don't need that (they mostly depended on justunimodules-core).minSdkVersion/targetSdkVersion/compileSdkVersionnot allowing to override versions through the root project configuration.Test Plan
All checks on the CI have passed. I've built the app locally and it works as well.