[client][android] account for notch/statusbar when displaying redbox #6644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esamelson
approved these changes
Jan 2, 2020
There was a problem hiding this comment.
Cool, thanks! This looks fine to me. Could you go ahead and make this PR to the sdk-36 branch of https://github.com/expo/react-native as well, so it gets maintained in future sdk versions? We might also want to consider upstreaming this if it's an issue in bare RN as well.
cruzach
added a commit
to expo/react-native
that referenced
this pull request
Jan 3, 2020
|
Doesn't look to be a problem with bare RN, although I'm not sure why added to expo/react-native sdk-36 branch here |
|
Thanks!
Excuse my ignorance, but is anything else needed for me to get the fix? Or is there some other issue I can track for when a patch release is made? |
|
@SimenB - at this time we don't have any plans to release a patch version of SDK 36 that includes this fix, so it will most likely this fix will go out with our next SDK version, which we expect to release in March. |
tsapeta
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 25, 2020
sjchmiela
pushed a commit
to expo/react-native
that referenced
this pull request
May 14, 2020
sjchmiela
pushed a commit
to expo/react-native
that referenced
this pull request
May 14, 2020
sjchmiela
pushed a commit
to expo/react-native
that referenced
this pull request
May 19, 2020
EvanBacon
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 27, 2020
EvanBacon
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 9, 2020
EvanBacon
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 11, 2020
EvanBacon
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 23, 2020
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 19, 2021
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Jan 9, 2022
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 17, 2022
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 18, 2022
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 23, 2022
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 2, 2022
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 14, 2022
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
May 13, 2022
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
May 23, 2022
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
May 24, 2022
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 23, 2022
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 29, 2022
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 6, 2025
vonovak
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 21, 2025
vonovak
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 21, 2025
vonovak
pushed a commit
to expo/react-native
that referenced
this pull request
Feb 25, 2025
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 7, 2025
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 14, 2025
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 18, 2025
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 25, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Mar 26, 2025
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 1, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 3, 2025
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 8, 2025
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Apr 15, 2025
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
May 1, 2025
chrfalch
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 2, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 4, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 5, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 9, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 12, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 18, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 18, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 1, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 1, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 1, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 31, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 31, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Aug 5, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Aug 12, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Aug 15, 2025
gabrieldonadel
pushed a commit
to expo/react-native
that referenced
this pull request
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
closes #6542
also looks like the top of the redbox was covered by statusbar in non-notch devices
Test Plan
Tested on notch sim & non-notch sim: