[Permissions] Move logic form module to service #5186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
reviewed
Aug 6, 2019
packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsModule.kt
Outdated
Show resolved
Hide resolved
packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt
Show resolved
Hide resolved
046f9a4 to
c11218b
Compare
bbarthec
reviewed
Aug 8, 2019
...sions/android/src/main/java/expo/modules/permissions/requesters/SystemBrightnessRequester.kt
Outdated
Show resolved
Hide resolved
bbarthec
reviewed
Aug 8, 2019
...sions/android/src/main/java/expo/modules/permissions/requesters/SystemBrightnessRequester.kt
Outdated
Show resolved
Hide resolved
| public interface Permissions { | ||
|
|
||
| Bundle getPermissionsBundle(String[] permissionTypes); |
There was a problem hiding this comment.
I started to wonder why are we using String[] instead of List<String> here, in the whole interface? I guess we have some conversion from List at the beginning (as RN provides us with sth List-like) and vice-verse and the end we probably convert to List-like again. Maybe we can get rid of these arrays in favour of List-like interfaces? 🤔
There was a problem hiding this comment.
Later, I will try to get rid of strings arrays.
packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt
Show resolved
Hide resolved
packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt
Show resolved
Hide resolved
packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt
Show resolved
Hide resolved
packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt
Show resolved
Hide resolved
packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt
Show resolved
Hide resolved
packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsService.kt
Show resolved
Hide resolved
lukmccall
added a commit
that referenced
this pull request
Aug 8, 2019
* Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions
lukmccall
added a commit
that referenced
this pull request
Aug 19, 2019
* Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions
lukmccall
added a commit
that referenced
this pull request
Sep 16, 2019
* Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions
lukmccall
added a commit
that referenced
this pull request
Oct 22, 2019
* Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions
lukmccall
added a commit
that referenced
this pull request
Oct 23, 2019
* Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions
lukmccall
added a commit
that referenced
this pull request
Oct 24, 2019
* Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions
lukmccall
added a commit
that referenced
this pull request
Oct 28, 2019
* Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions
lukmccall
added a commit
that referenced
this pull request
Nov 4, 2019
* Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions
lukmccall
added a commit
that referenced
this pull request
Nov 8, 2019
* Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions
lukmccall
added a commit
that referenced
this pull request
Nov 8, 2019
* [Permissions] Extract base class for requester * [Permissions] Refactor * [Permissions] Make podspecs for each requester * [Permissions] Add missing self ensurement to requesters * [Permissions] Android fix * [Permissions] Rewrite module to kotlin * [Permissions] Move scoped ask to activity * [Permissions] Remove permissions manager * [Permissions] Remove PermissionsServiceBinding * [Permissions] Make requesters * [Permissions] Improve code styling * [Permissions] Make SystemBrightnessRequester (#5147) * Make SystemBrightnessRequester * Make type enum Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com> * [Permissions] Rewrite android native api (#5186) * Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions * [Permissions] Make requester registrable (#5187) * Clean iOS * Fix scoped permissions status (never undetermined) * Requesters belong to EXPermission * Remove permissions delegate * Make requester registrable * [Permissions] Small fixes * [Permissions] Add app ownership check and fix code style * [Permissions] Rework native api (#5418) * [Permissions] Move requesters to modules on iOS * [Permissions] Add bool granted * [Permissions] Add to native modules, permissions related methods * [Permissions] Repair CI * [Permissions] Fix typo * [Permissions] Reduce boilerplate code * [Permissions] Fix error description * [Permissions] Export constants for permissions status * [Permissions] Rename methods wrapper * [Permissions] Remove scoped permissions from standalone apps * [Permissions] Fix lateinit and scoped permissions Location module in OnHostResume calls getPermissions method before Activity Provider is available. * [Permissions] Add `never ask again` support * [Permissions] Scoping only dangerous permission * [Permissions] Rename `neverAskAgain` to `canAskAgain` * [Permissions] Run pod install * [Permissions] Update docs * [Permissions] Fix CI * [Permissions] Fix typo and imports after rebase * [Permissions] Small improvements in Android * [Permissions] Make test-suits pass * [Permissions] Add requested changes * [Permissions] Move ts types to unimodule * [Permissions] Add missing requester * [Permissions] Small fixes * [Permissions] Fix after rebase * [Permissions] Update docs * [Permissions] Publish dev home * [Permissions] Add kotlin dependency to build.gradle * [Permissions] Fix permissions in ContactsModule * [Permissions] Set manifest in HomeActivity class * [Permissions] Regenerate pods projects
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
* [Permissions] Extract base class for requester * [Permissions] Refactor * [Permissions] Make podspecs for each requester * [Permissions] Add missing self ensurement to requesters * [Permissions] Android fix * [Permissions] Rewrite module to kotlin * [Permissions] Move scoped ask to activity * [Permissions] Remove permissions manager * [Permissions] Remove PermissionsServiceBinding * [Permissions] Make requesters * [Permissions] Improve code styling * [Permissions] Make SystemBrightnessRequester (expo#5147) * Make SystemBrightnessRequester * Make type enum Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com> * [Permissions] Rewrite android native api (expo#5186) * Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions * [Permissions] Make requester registrable (expo#5187) * Clean iOS * Fix scoped permissions status (never undetermined) * Requesters belong to EXPermission * Remove permissions delegate * Make requester registrable * [Permissions] Small fixes * [Permissions] Add app ownership check and fix code style * [Permissions] Rework native api (expo#5418) * [Permissions] Move requesters to modules on iOS * [Permissions] Add bool granted * [Permissions] Add to native modules, permissions related methods * [Permissions] Repair CI * [Permissions] Fix typo * [Permissions] Reduce boilerplate code * [Permissions] Fix error description * [Permissions] Export constants for permissions status * [Permissions] Rename methods wrapper * [Permissions] Remove scoped permissions from standalone apps * [Permissions] Fix lateinit and scoped permissions Location module in OnHostResume calls getPermissions method before Activity Provider is available. * [Permissions] Add `never ask again` support * [Permissions] Scoping only dangerous permission * [Permissions] Rename `neverAskAgain` to `canAskAgain` * [Permissions] Run pod install * [Permissions] Update docs * [Permissions] Fix CI * [Permissions] Fix typo and imports after rebase * [Permissions] Small improvements in Android * [Permissions] Make test-suits pass * [Permissions] Add requested changes * [Permissions] Move ts types to unimodule * [Permissions] Add missing requester * [Permissions] Small fixes * [Permissions] Fix after rebase * [Permissions] Update docs * [Permissions] Publish dev home * [Permissions] Add kotlin dependency to build.gradle * [Permissions] Fix permissions in ContactsModule * [Permissions] Set manifest in HomeActivity class * [Permissions] Regenerate pods projects
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
* [Permissions] Extract base class for requester * [Permissions] Refactor * [Permissions] Make podspecs for each requester * [Permissions] Add missing self ensurement to requesters * [Permissions] Android fix * [Permissions] Rewrite module to kotlin * [Permissions] Move scoped ask to activity * [Permissions] Remove permissions manager * [Permissions] Remove PermissionsServiceBinding * [Permissions] Make requesters * [Permissions] Improve code styling * [Permissions] Make SystemBrightnessRequester (expo#5147) * Make SystemBrightnessRequester * Make type enum Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com> * [Permissions] Rewrite android native api (expo#5186) * Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions * [Permissions] Make requester registrable (expo#5187) * Clean iOS * Fix scoped permissions status (never undetermined) * Requesters belong to EXPermission * Remove permissions delegate * Make requester registrable * [Permissions] Small fixes * [Permissions] Add app ownership check and fix code style * [Permissions] Rework native api (expo#5418) * [Permissions] Move requesters to modules on iOS * [Permissions] Add bool granted * [Permissions] Add to native modules, permissions related methods * [Permissions] Repair CI * [Permissions] Fix typo * [Permissions] Reduce boilerplate code * [Permissions] Fix error description * [Permissions] Export constants for permissions status * [Permissions] Rename methods wrapper * [Permissions] Remove scoped permissions from standalone apps * [Permissions] Fix lateinit and scoped permissions Location module in OnHostResume calls getPermissions method before Activity Provider is available. * [Permissions] Add `never ask again` support * [Permissions] Scoping only dangerous permission * [Permissions] Rename `neverAskAgain` to `canAskAgain` * [Permissions] Run pod install * [Permissions] Update docs * [Permissions] Fix CI * [Permissions] Fix typo and imports after rebase * [Permissions] Small improvements in Android * [Permissions] Make test-suits pass * [Permissions] Add requested changes * [Permissions] Move ts types to unimodule * [Permissions] Add missing requester * [Permissions] Small fixes * [Permissions] Fix after rebase * [Permissions] Update docs * [Permissions] Publish dev home * [Permissions] Add kotlin dependency to build.gradle * [Permissions] Fix permissions in ContactsModule * [Permissions] Set manifest in HomeActivity class * [Permissions] Regenerate pods projects
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
* [Permissions] Extract base class for requester * [Permissions] Refactor * [Permissions] Make podspecs for each requester * [Permissions] Add missing self ensurement to requesters * [Permissions] Android fix * [Permissions] Rewrite module to kotlin * [Permissions] Move scoped ask to activity * [Permissions] Remove permissions manager * [Permissions] Remove PermissionsServiceBinding * [Permissions] Make requesters * [Permissions] Improve code styling * [Permissions] Make SystemBrightnessRequester (expo#5147) * Make SystemBrightnessRequester * Make type enum Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com> * [Permissions] Rewrite android native api (expo#5186) * Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions * [Permissions] Make requester registrable (expo#5187) * Clean iOS * Fix scoped permissions status (never undetermined) * Requesters belong to EXPermission * Remove permissions delegate * Make requester registrable * [Permissions] Small fixes * [Permissions] Add app ownership check and fix code style * [Permissions] Rework native api (expo#5418) * [Permissions] Move requesters to modules on iOS * [Permissions] Add bool granted * [Permissions] Add to native modules, permissions related methods * [Permissions] Repair CI * [Permissions] Fix typo * [Permissions] Reduce boilerplate code * [Permissions] Fix error description * [Permissions] Export constants for permissions status * [Permissions] Rename methods wrapper * [Permissions] Remove scoped permissions from standalone apps * [Permissions] Fix lateinit and scoped permissions Location module in OnHostResume calls getPermissions method before Activity Provider is available. * [Permissions] Add `never ask again` support * [Permissions] Scoping only dangerous permission * [Permissions] Rename `neverAskAgain` to `canAskAgain` * [Permissions] Run pod install * [Permissions] Update docs * [Permissions] Fix CI * [Permissions] Fix typo and imports after rebase * [Permissions] Small improvements in Android * [Permissions] Make test-suits pass * [Permissions] Add requested changes * [Permissions] Move ts types to unimodule * [Permissions] Add missing requester * [Permissions] Small fixes * [Permissions] Fix after rebase * [Permissions] Update docs * [Permissions] Publish dev home * [Permissions] Add kotlin dependency to build.gradle * [Permissions] Fix permissions in ContactsModule * [Permissions] Set manifest in HomeActivity class * [Permissions] Regenerate pods projects
Eric-Tyrrell22
pushed a commit
to Eric-Tyrrell22/expo
that referenced
this pull request
Aug 14, 2025
* [Permissions] Extract base class for requester * [Permissions] Refactor * [Permissions] Make podspecs for each requester * [Permissions] Add missing self ensurement to requesters * [Permissions] Android fix * [Permissions] Rewrite module to kotlin * [Permissions] Move scoped ask to activity * [Permissions] Remove permissions manager * [Permissions] Remove PermissionsServiceBinding * [Permissions] Make requesters * [Permissions] Improve code styling * [Permissions] Make SystemBrightnessRequester (expo#5147) * Make SystemBrightnessRequester * Make type enum Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com> * [Permissions] Rewrite android native api (expo#5186) * Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions * [Permissions] Make requester registrable (expo#5187) * Clean iOS * Fix scoped permissions status (never undetermined) * Requesters belong to EXPermission * Remove permissions delegate * Make requester registrable * [Permissions] Small fixes * [Permissions] Add app ownership check and fix code style * [Permissions] Rework native api (expo#5418) * [Permissions] Move requesters to modules on iOS * [Permissions] Add bool granted * [Permissions] Add to native modules, permissions related methods * [Permissions] Repair CI * [Permissions] Fix typo * [Permissions] Reduce boilerplate code * [Permissions] Fix error description * [Permissions] Export constants for permissions status * [Permissions] Rename methods wrapper * [Permissions] Remove scoped permissions from standalone apps * [Permissions] Fix lateinit and scoped permissions Location module in OnHostResume calls getPermissions method before Activity Provider is available. * [Permissions] Add `never ask again` support * [Permissions] Scoping only dangerous permission * [Permissions] Rename `neverAskAgain` to `canAskAgain` * [Permissions] Run pod install * [Permissions] Update docs * [Permissions] Fix CI * [Permissions] Fix typo and imports after rebase * [Permissions] Small improvements in Android * [Permissions] Make test-suits pass * [Permissions] Add requested changes * [Permissions] Move ts types to unimodule * [Permissions] Add missing requester * [Permissions] Small fixes * [Permissions] Fix after rebase * [Permissions] Update docs * [Permissions] Publish dev home * [Permissions] Add kotlin dependency to build.gradle * [Permissions] Fix permissions in ContactsModule * [Permissions] Set manifest in HomeActivity class * [Permissions] Regenerate pods projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Part of #5061.