[Permission] Rework #5061

lukmccall · 2019-07-24T13:50:37Z

Why

Resolves #4972.
Resolves #5831.
Resolves #4289.
Resolves #4618.

How

iOS
- general clean up.
- move logic responsible for asking/getting more than one permission to js side.
- extract base class for requesters.
- move each requester to separate podspec.
- remove `EXPermissionsModule protocol.
- make requesters registrable.
- add [_constantsBinding.appOwnership isEqualToString:@"expo"] to EXScopedPermissions. (see)
- modules, which need permissions should have own native method to handle own permission.
  - move requesters to modules
Android
- rewrite to kotlin.
- general clean up.
- move logic responsible for scoped permission ask to activity.
- remove PermissionsManager.
- remove PermissionsServiceBinding.
- clean PermissionsModule class.
- do something with systemBrightness.
- cache mPermissionsAskedFor.
- modules, which need permissions should have own native method to handle own permission.
  - move logic from PermissionsModule to PermissionsService
  - rewrite native api for permissions - make it similar to iOS
  - use List insted of String[] in native interface
  - move requsters to modules
- resolve react-native-webview - File download without granted storage permission crashes app on Android #5831.
Both
- resolve [Android][expo-permissions] No ability to distinguish when a user has denied access with "Don't ask again" check #4289.
- resolve Permissions.getAsync() results inconsistent with iOS settings after upgrade to ExpoKit 33 #4618 (not fixed in expo client).

Flowgraph

iOS
Android

Test Plan

test-suite passed.
I tested it with a simple demo (run on several experiences to be able to test scoped permissions).

Test cases:

Test	Android	iOS
Permissions are properly set in settings.	🆗	🆗
Permissions are properly scoped (switching between two apps).	🆗	🆗
Global combined status is correct.	🆗	🆗
Scoped status is correct (the previous test but enforce using scoped permission).	🆗	🆗
Check if `canAskAgain` and `granted` fields have the correct value.	🆗	🆗
Test added module methods (getting/asking using, for example, the `Camera` module).	🆗	🆗
Test backward compatibility.	🆗	🆗
Changing permissions in system settings.	🆗	🆗
Bare workflow.	🆗	🆗

packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsModule.kt

packages/expo-permissions/src/Permissions.ts

...expo-permissions/ios/EXPermissions/Requesters/UserNotification/EXUserNotificationRequester.h

...-permissions/ios/EXPermissions/Requesters/RemoteNotification/EXRemoteNotificationRequester.h

packages/expo-permissions/ios/EXPermissions/Requesters/Camera/EXCameraPermissionRequester.m

android/expoview/src/main/java/host/exp/exponent/utils/PermissionsHelper.java

android/expoview/src/main/java/host/exp/exponent/experience/DetachedModuleRegistryAdapter.java

android/expoview/src/main/java/host/exp/exponent/experience/BaseExperienceActivity.java

ios/Exponent/Versioned/Core/UniversalModules/Permissions/EXScopedPermissions.m

…5166) # Why There are some use cases where we want to pick media assets from some specific period of time, like during a visit in a food place. That use case is also used in Gyroscope app where I wanted to make it work more smoothly and get rid of filtering all the assets in JS. # How Added `createdAfter` and `createdBefore` options to `MediaLibrary.getAssetsAsync` and also added `requestPermissionsAsync` and `getPermissionsAsync` functions which would also be a part of #5061 but I decided to include them earlier so I don't have to migrate in the future releases 😅 # Test Plan Added tests to test-suite + I tested it in Gyroscope app

...o-permissions/android/src/main/java/expo/modules/permissions/requesters/CalendarRequester.kt

...permissions/android/src/main/java/expo/modules/permissions/requesters/CameraRollRequester.kt

...o-permissions/android/src/main/java/expo/modules/permissions/requesters/LocationRequester.kt

...rmissions/android/src/main/java/expo/modules/permissions/requesters/NotificationRequester.kt

...permissions/android/src/main/java/expo/modules/permissions/requesters/PermissionRequester.kt

...xpo-permissions/android/src/main/java/expo/modules/permissions/requesters/SimpleRequester.kt

packages/expo-permissions/ios/EXPermissions/EXPermissionBaseRequester.m

packages/expo-permissions/ios/EXPermissions/EXPermissions.m

packages/expo-permissions/src/Permissions.ts

bbarthec

LGTM 💯 Amazing work 👍
One suggestion:
Maybe these's some clever way to rewrite

%{
	@"status": sth,
	@"expires": sth
}

into some POJO-style or NSDictionary-based?

There are many places where this construction is used and it's always typed by hand, but maybe we can somehow enforce more class-based behaviours instead of JSON-like behaviour.

android/expoview/src/main/java/host/exp/exponent/experience/DetachedModuleRegistryAdapter.java

android/expoview/src/main/java/host/exp/expoview/Exponent.java

ios/Exponent/Versioned/Core/UniversalModules/Permissions/EXScopedPermissions.m

packages/expo-permissions/ios/EXPermissions/EXPermissions.m

packages/unimodules-permissions-interface/ios/UMPermissionsInterface/UMPermissionsInterface.h

* [Permissions] Extract base class for requester * [Permissions] Refactor * [Permissions] Make podspecs for each requester * [Permissions] Add missing self ensurement to requesters * [Permissions] Android fix * [Permissions] Rewrite module to kotlin * [Permissions] Move scoped ask to activity * [Permissions] Remove permissions manager * [Permissions] Remove PermissionsServiceBinding * [Permissions] Make requesters * [Permissions] Improve code styling * [Permissions] Make SystemBrightnessRequester (expo#5147) * Make SystemBrightnessRequester * Make type enum Co-Authored-By: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com> * [Permissions] Rewrite android native api (expo#5186) * Move logic form module to service * Remove static var from PermissionsService * Make getPermission not throwable * Store asked permissions * [Permissions] Make requester registrable (expo#5187) * Clean iOS * Fix scoped permissions status (never undetermined) * Requesters belong to EXPermission * Remove permissions delegate * Make requester registrable * [Permissions] Small fixes * [Permissions] Add app ownership check and fix code style * [Permissions] Rework native api (expo#5418) * [Permissions] Move requesters to modules on iOS * [Permissions] Add bool granted * [Permissions] Add to native modules, permissions related methods * [Permissions] Repair CI * [Permissions] Fix typo * [Permissions] Reduce boilerplate code * [Permissions] Fix error description * [Permissions] Export constants for permissions status * [Permissions] Rename methods wrapper * [Permissions] Remove scoped permissions from standalone apps * [Permissions] Fix lateinit and scoped permissions Location module in OnHostResume calls getPermissions method before Activity Provider is available. * [Permissions] Add `never ask again` support * [Permissions] Scoping only dangerous permission * [Permissions] Rename `neverAskAgain` to `canAskAgain` * [Permissions] Run pod install * [Permissions] Update docs * [Permissions] Fix CI * [Permissions] Fix typo and imports after rebase * [Permissions] Small improvements in Android * [Permissions] Make test-suits pass * [Permissions] Add requested changes * [Permissions] Move ts types to unimodule * [Permissions] Add missing requester * [Permissions] Small fixes * [Permissions] Fix after rebase * [Permissions] Update docs * [Permissions] Publish dev home * [Permissions] Add kotlin dependency to build.gradle * [Permissions] Fix permissions in ContactsModule * [Permissions] Set manifest in HomeActivity class * [Permissions] Regenerate pods projects

lukmccall mentioned this pull request Jul 24, 2019

[Permissions] Major rework #4972

Closed

lukmccall force-pushed the @lukmccall/permissions-rework branch from 6351791 to f859223 Compare July 25, 2019 14:06

lukmccall requested review from bbarthec and tsapeta July 25, 2019 14:07

lukmccall force-pushed the @lukmccall/permissions-rework branch from f859223 to f611d80 Compare July 25, 2019 14:38

lukmccall commented Jul 26, 2019

View reviewed changes

packages/expo-permissions/android/src/main/java/expo/modules/permissions/PermissionsModule.kt Outdated Show resolved Hide resolved

lukmccall changed the title ~~[Permission] Rework - refactor~~ [Permission] Rework Jul 30, 2019

bbarthec reviewed Jul 31, 2019

View reviewed changes

lukmccall requested a review from bbarthec August 1, 2019 08:16

lukmccall force-pushed the @lukmccall/permissions-rework branch from 14e9f5a to 1c9c53d Compare August 1, 2019 10:26

lukmccall mentioned this pull request Aug 1, 2019

[Permissions] Make SystemBrightnessRequester #5147

Merged

tsapeta mentioned this pull request Aug 5, 2019

[media-library] Allow to get assets created in specified time range #5166

Merged

This was referenced Aug 5, 2019

[Permissions] Move logic form module to service #5186

Merged

[Permissions] Make requester registrable #5187

Merged

bbarthec reviewed Aug 8, 2019

View reviewed changes

bbarthec requested review from mczernek and Szymon20000 and removed request for mczernek August 8, 2019 11:45

lukmccall force-pushed the @lukmccall/permissions-rework branch 2 times, most recently from c443b83 to abcda97 Compare August 8, 2019 15:28

lukmccall requested a review from bbarthec August 9, 2019 08:02

bbarthec mentioned this pull request Aug 9, 2019

[iOS] Fix NOTIFICATION permission prior SDK32 #3510

Merged

bbarthec reviewed Aug 12, 2019

View reviewed changes

lukmccall force-pushed the @lukmccall/permissions-rework branch from 0ac9f30 to d693a5f Compare August 19, 2019 08:19

bbarthec mentioned this pull request Aug 19, 2019

Permissions.getAsync() results inconsistent with iOS settings after upgrade to ExpoKit 33 #4618

Closed

lukmccall mentioned this pull request Aug 22, 2019

[Permissions] Add native api #5418

Merged

lukmccall force-pushed the @lukmccall/permissions-rework branch from 9e44c59 to 6fa4662 Compare September 16, 2019 15:15

lukmccall marked this pull request as ready for review September 23, 2019 08:01

lukmccall requested a review from EvanBacon as a code owner September 23, 2019 08:01

lukmccall added 18 commits November 8, 2019 12:24

[Permissions] Run pod install

46715f9

[Permissions] Update docs

71eab57

[Permissions] Fix

e1bbd4b

[Permissions] Fix CI

e9081f4

[Permissions] Fix linter warnings

6099f2c

[Permissions] Fix typo and imports after rebase

774bcd0

[Permissions] Small improvements in Android

7238cae

[Permissions] Make test-suits pass

aa9ca0e

[Permissions] Add requested changes

b65537e

[Permissions] Move ts types to unimodule

783ef7c

[Permissions] Add missing requester

7e91b4a

[Permissions] Small fixes

9e8e58b

[Permissions] Fix after rebase

8cca38e

[Permissions] Update docs

575295b

[Permissions] Publish dev home

7751b43

[Permissions] Add kotlin dependency to build.gradle

9f54e7c

[Permissions] Fix permissions in ContactsModule

1e445ee

[Permissions] Set manifest in HomeActivity class

73ed152

lukmccall force-pushed the @lukmccall/permissions-rework branch from d3426d4 to ae0aa78 Compare November 8, 2019 12:27

[Permissions] Regenerate pods projects

26c161e

lukmccall force-pushed the @lukmccall/permissions-rework branch from ae0aa78 to 26c161e Compare November 8, 2019 15:08

lukmccall merged commit 284d484 into master Nov 8, 2019

lukmccall deleted the @lukmccall/permissions-rework branch November 8, 2019 15:51

esamelson mentioned this pull request Nov 21, 2019

[android] Scoped permissions are always denied on SDK 36 #6339

Closed

brentvatne mentioned this pull request Dec 12, 2019

[docs] Update react-native-unimodules README for new modular permissions setup #6509

Closed

brentvatne mentioned this pull request Jan 13, 2020

[image-picker][sharing] Small fixes while working on tutorial #6757

Merged

[Permission] Rework #5061

[Permission] Rework #5061

Uh oh!

Conversation

lukmccall commented Jul 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

How

Flowgraph

Test Plan

Test cases:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbarthec left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukmccall commented Jul 24, 2019 •

edited

Loading

bbarthec left a comment •

edited

Loading