[sdk] Remove uses of UIWebView #5578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c159f1 to
afb5b6b
Compare
tsapeta
approved these changes
Sep 9, 2019
ide
approved these changes
Sep 10, 2019
| [window addSubview:_containerView]; | ||
|
|
||
| UM_WEAKIFY(self); | ||
| dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(0.1 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{ |
There was a problem hiding this comment.
What is this delay waiting for? Is it something we can wait for explicitly rather than hoping that 100ms is correct?
There was a problem hiding this comment.
I didn't find a better way to trigger WKWebView's rendering. Without the delay the only things that are rendered are divs, no text.
There was a problem hiding this comment.
Added small explanatory comment
https://github.com/expo/expo/pull/5578/files#diff-b21043019b44ad078174d6a97c441b38R41-R42
afb5b6b to
bd05e1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Otherwise Apple may reject our apps.
How
Reimplemented
expo-printfunctionality usingWKWebView.x-ref: expo/react-native#17
Test Plan
NCL Print screen looks ok.