[webbrowser][android]Add configuration option to show web browser in … #5442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recents on android.
sjchmiela
requested changes
Aug 27, 2019
packages/expo-web-browser/android/src/main/java/expo/modules/webbrowser/WebBrowserModule.java
Outdated
Show resolved
Hide resolved
packages/expo-web-browser/android/src/main/java/expo/modules/webbrowser/WebBrowserModule.java
Outdated
Show resolved
Hide resolved
…ebbrowser/WebBrowserModule.java Co-Authored-By: Stanisław Chmiela <sjchmiela@users.noreply.github.com>
Co-Authored-By: Stanisław Chmiela <sjchmiela@users.noreply.github.com>
Co-Authored-By: Stanisław Chmiela <sjchmiela@users.noreply.github.com>
…ebbrowser/WebBrowserModule.java Co-Authored-By: Stanisław Chmiela <sjchmiela@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…recents on android.
Why
Fix in WebBrowser introduced behavior that is not expected by users, even though we introduced it consciously. Hence, we want to give users an option to configure showing/hiding web browser i recents in cases they find default behavior wrong.
Test Plan
There is new switch in WebBrowser screen in NCL.