Skip to content

Conversation

abduraufsherkulov
Copy link

@abduraufsherkulov abduraufsherkulov commented Jan 26, 2019

How

How did you build this feature or fix this bug and why?

I just noticed while working with FlatView.

@nicknovitski
Copy link
Member

😮 Thank you for catching this!

@nicknovitski
Copy link
Member

There's actually many react-native pages with code like ${"{"}. I think it's caused by a bug in the script we use to import them. @ccheever @ide

@nicknovitski
Copy link
Member

nicknovitski commented Jan 28, 2019

Looks like it's these lines. Which would means inCodeBlock is false when it shouldn't be?

@ide
Copy link
Member

ide commented Jan 28, 2019

I opened up #3356 for the long term fix. It looks like this PR has a merge conflict, though -- perhaps the bug at hand was fixed?

@nicknovitski
Copy link
Member

No, still there. I'll take care of it.

@nicknovitski
Copy link
Member

Sorry @abduraufsherkulov, I created the merge conflict by rearranging the docs directory. Instead of telling you to rebase, I'm going to close this PR in favor of #3399, where I fixed all of the errors I could find, but it's all thanks to you. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants