Skip to content

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Nov 5, 2024

Why

fix the issue when long-press r in cli and makes expo-go stuck in loading view

How

  • call destroyReactHost on ReactNativeActivity.onDestroy. we did similar destroy on bridge expo-go as well.
  • since the multi-activity expo-go will destory the current activity, the destroyReactHost should destroy ReactHost instance.
  • prevent "home" react instance create a packager connection. we should use ReleaseDevSupportManager for "home" in production build.
  • remove unused code in VersionedUtils.kt
  • also Fix android reload reentrant issue react-native#39

Test Plan

keep pressing r in cli and see if expo-go stuck on loading view

Checklist

Copy link

linear bot commented Nov 5, 2024

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Nov 5, 2024
@Kudo Kudo marked this pull request as ready for review November 5, 2024 16:50
@Kudo Kudo requested a review from alanjhughes November 5, 2024 16:50
@Kudo Kudo merged commit 331f51d into main Nov 5, 2024
7 checks passed
@Kudo Kudo deleted the @kudo/eng-14048-expo-go-for-android-sometimes-gets-stuck-on-loading-screen branch November 5, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants