Enhance file search performance using fast-glob #27551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
|
It's ready to review, anything I can improve more? @EvanBacon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR implements anyMatchAsync with fast-glob to leverage its lighter, faster capabilities as a replacement for glob. The expected outcome is improved time efficiency in file searching.
Previously, the reliance on everyMatchAsync was due to glob's lack of support for an abort controller, resulting in prolonged search times for files matching a pattern. fast-glob introduces a stream() method enabling early return upon finding the first matched file, thereby optimizing the search process.
How
The transition to fast-glob was motivated by the need for a more efficient file search mechanism. By replacing glob with fast-glob, we utilize its streamlined file pattern matching and early return capabilities, significantly improving search performance and code maintainability.
This is my first pull request 🙇🏻♂️. I intend to add a performance comparison between the before and after states. Could you offer some guidance on how to proceed?
Test Plan
There is a test, and manual test
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).