fix(cli): add back legacy inspector js middleware for dev menu #25883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Stacked on top of #25881
Correction of #25671
This was in place for the dev menu, and I deleted it a bit too early in #25671.
We can only delete this once we fully swapped over to
@react-native/dev-middleware, which is currently only used for the inspector proxy infrastructure.How
createJsInspectorMiddlewarefrom feature(cli): addEXPO_USE_UNSTABLE_DEBUGGERto enable the new React Native JS Inspector #25671Test Plan
$ bun create expo ./test-devmenu-debugger --template blank@50$ cd ./test-devmenu-debugger$ bun expo install expo-dev-client$ bun expo startmin terminalChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).