Skip to content

Make expo-store-review work in bare #6712

@superphil0

Description

@superphil0

🐛 Bug Report

Environment

Expo CLI 3.11.3 environment info:
System:
OS: Windows 10
Binaries:
Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.9.0 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: Version 3.5.0.0 AI-191.8026.42.35.5900203

building for android in the bare workflow (ejected from SDK 36)

Steps to Reproduce

StoreReview.requestReview()

Expected Behavior

store review works

Actual Behavior

does not work with [TypeError: null is not an object (evaluating 'manifest.android')]

this is because manifest is not available from expo-constants in bare

I think it would be very simple to fix by just providing the possibility to supply a store url yourself
to the requestReview function

If this does not fit, then please add https://github.com/expo/expo/tree/84ac8b85b13ba3c5a692701bed2170046d2b0802/packages/expo-store-review

here that it doesnt work in bare

Reproducible Demo

expo init
expo install expo-store-review
expo eject

in App.js
StoreReview.requestReview()

npm run android

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions