This repository was archived by the owner on Jan 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 479
Redesign Expo web PWA system #1686
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This was referenced Mar 20, 2020
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
PWAs in expo web are too fragile, not customizable enough, and only work in the default expo web workflow (not Next.js or Gatsby). The missing parts of Expo webpack made websites feel too much like a template and not enough like a robust website, this fixes that.
expo build:web
will automatically skip any PWA asset that's already linked in the project's localweb/index.html
.How
expo build:web --no-pwa
now works to fully disable the PWA files (not offline (pending further input)).app.config.js
settings (backgroundColor, resizeMode, image).WebpackPWAManifestPlugin
in favor of a few more scalable plugins.expo/pwa
package fromexpo/config
.supportsTablet
fromexpo.web.splash
since tablet PWAs cannot be disabled.manifest.json
icons
has too many images added to it.