This repository was archived by the owner on Jan 18, 2024. It is now read-only.
[expo-cli] Add firebase web-config support #1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
reviewed
Feb 19, 2020
| /** | ||
| * [Firebase Configuration Object](https://support.google.com/firebase/answer/7015592) Firebase web configuration. | ||
| */ | ||
| firebase?: { |
There was a problem hiding this comment.
Perhaps googleServicesFile so it matches iOS and Android?
There was a problem hiding this comment.
I initially considered that as well, but was having trouble parsing the file through the webpack plugin. My code wasn't being called in places where I expected it. And in createEnvironmentConstants I couldn't access (or don't know how to safely) the project-root.
Do you have any recommendations for me?
EvanBacon
approved these changes
Feb 19, 2020
brentvatne
approved these changes
Feb 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for putting the firebase web configuration in
app.json. This is uses for auto-configuration of firebase on Web and to make Firebase Analytics possible on the standard Expo Client, through a pure JS Firebase Analytics tracker which requires the web-configmeasurementId.