refactor: update image struct to reduce complexity of lib.rs #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exdx
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
LGTM, I think you have another PR that will follow-up this one and make the code even cleaner? I'd like to get rid of the branching if docker else podman logic altogether.
My only remark is that you should run cargo clippy locally to catch lint errors. It also helps rewrite code to make it more concise. I've updated the CI to correctly catch clippy formatting issues. Once you rebase and fix the clippy issues, feel free to merge.
|
Yes, I have another branch that removes the if paths entirely in favor of using an Image trait with two implementations: Docker and Podman. I'll get on clearing those local errors out. |
da07f4f to
555016c
Compare
555016c to
04754bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how the
imagestruct works. This takes a large portion of the complexity burden from thelib.rsfile and allows us to have theimagestruct have more functionality. In addition to this, the majority of this functionality has been logically compartmentalized into functions.