fix: add support for windows builds #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exdx
approved these changes
Sep 8, 2022
69ab817 to
44a19a1
Compare
Signed-off-by: Tyler Slaton <mtslaton1@gmail.com>
44a19a1 to
ec69931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding some conditional compilation that enables builds to finish in windows environments. Prior to this PR,
xdgwas not allowing our builds to be cross-platform compatible. This conditionally compiles that import and sets a logical default for supporting Docker (not Podman, yet) in a windows environment.Tangentially, this also updates the error messaging for not being able to connect to sockets to be clearer.
Todo
dcpon WindowsCloses #14