Skip to content

feat: add support for --socket to specify custom sockets #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2022
Merged

feat: add support for --socket to specify custom sockets #59

merged 1 commit into from
Sep 8, 2022

Conversation

tylerslaton
Copy link
Collaborator

@tylerslaton tylerslaton commented Sep 6, 2022 •
edited
Loading

Summary

Adding a new --socket option that allow users to specify custom socket locations

Closes #36

@tylerslaton tylerslaton requested a review from exdx September 6, 2022 01:34
exdx
exdx reviewed Sep 6, 2022
View reviewed changes
Copy link
Owner

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd like to keep the podman socket defaulting in for now.

We can break this PR up if you like and just introduce custom socket support in a single commit (with no other changes), and worry about windows in a follow-up.

@exdx
Copy link
Owner

exdx commented Sep 6, 2022 •
edited
Loading

For example f94db97 looks good to merge as-is

@tylerslaton tylerslaton force-pushed the add-custom-socket-option branch 2 times, most recently from 1854da5 to a78a673 Compare September 6, 2022 03:53
@tylerslaton tylerslaton changed the title feat: add support for --socket to specify custom sockets and support for windows environments feat: add support for --socket to specify custom sockets Sep 6, 2022
@tylerslaton tylerslaton force-pushed the add-custom-socket-option branch from a78a673 to 1653b6f Compare September 7, 2022 23:35
@tylerslaton tylerslaton force-pushed the add-custom-socket-option branch from 1653b6f to e0d2310 Compare September 7, 2022 23:38
@tylerslaton tylerslaton marked this pull request as ready for review September 8, 2022 00:03
exdx
exdx approved these changes Sep 8, 2022
View reviewed changes
Copy link
Owner

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exdx exdx merged commit 8d101b3 into exdx:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exdx exdx exdx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom socket locations
2 participants
@tylerslaton @exdx