Skip to content

fix: Parse image tag for digest-based images #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2022
Merged

fix: Parse image tag for digest-based images #56

merged 1 commit into from
Sep 4, 2022

Conversation

exdx
Copy link
Owner

@exdx exdx commented Sep 4, 2022

Supports digest-based images

Closes #51

@exdx exdx requested a review from tylerslaton September 4, 2022 22:12
tylerslaton
tylerslaton reviewed Sep 4, 2022
View reviewed changes
Copy link
Collaborator

@tylerslaton tylerslaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about this a bit offline, but perhaps we can get the detection of locally pulled images working for digests?

@exdx
Copy link
Owner Author

exdx commented Sep 4, 2022

Talked about this a bit offline, but perhaps we can get the detection of locally pulled images working for digests?

I think I might tackle this in a follow-up and keep this PR small in scope.

@exdx exdx merged commit 1c2b90b into main Sep 4, 2022
@exdx exdx mentioned this pull request Sep 7, 2022
Closed
@tylerslaton tylerslaton deleted the fix/digest-image-parsing branch September 8, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerslaton tylerslaton tylerslaton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for digest image references
2 participants
@exdx @tylerslaton