Skip to content

Raise an error on non-200 proxy CONNECT response #708

@jjiang-stripe

Description

@jjiang-stripe

When the CONNECT request fails with a non-200 response, Excon still attempts the SSL handshake which is doomed to fail. Because of this, we end up getting a misleading SSL error rather than the actual CONNECT failure. Could we raise an error here if the proxy connection fails?

When I dug through the commit history, there was a commit that used to do this, but got removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions