Fix match sorting algorithm #1314
Conversation
|
@FelipeGdM is attempting to deploy a commit to the evroon's projects Team on Vercel. A member of the Team first needs to authorize it. |
| stage_start_time = time_last_match_from_previous_stage | ||
| stage_position_in_schedule = position_last_match_from_previous_stage |
There was a problem hiding this comment.
These two lines are unnecessary right?
There was a problem hiding this comment.
You are right, they are redundant with lines 38-39
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for your quick review @evroon! I fixed the code following your suggestion |
|
Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1314 +/- ##
==========================================
+ Coverage 94.62% 94.94% +0.32%
==========================================
Files 118 118
Lines 4351 4335 -16
==========================================
- Hits 4117 4116 -1
+ Misses 234 219 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Oh could you run Ruff? |
|
No problem! |
Head branch was pushed to by a user without write access
This PR alters the match scheduling logic
Now, the algorithm schedules all matches for each stage in sequence (i.e. all matches from stage A, then all matches from stage B). Matches from stage items inside a single stage are interleaved.
To guarantee that the correct order is followed, rounds are sorted according to their id. Lower round id are scheduled first.
Fix #1312