Skip to content

Conversation

jmillxyz
Copy link
Contributor

@jmillxyz jmillxyz commented May 5, 2025

Hi there, cool project. I appreciated seeing a working example of FastAPI + NextJS together.

I noticed the teams table didn't show each team member in the members column, so here's a small PR to do so. Feel free to suggest edits!

Screenshot:
Screenshot 2025-05-05 at 12 24 51 PM

Copy link

vercel bot commented May 5, 2025

@jmillxyz is attempting to deploy a commit to the evroon's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Actay893
Copy link

Actay893 commented May 8, 2025

Hey there! I am new to APIs, why are you using FastAPI ad nextJS together and what does it actually accomplish in this project? Thank you for your time in advance!

@evroon
Copy link
Owner

evroon commented May 8, 2025

Hey there! I am new to APIs, why are you using FastAPI ad nextJS together and what does it actually accomplish in this project? Thank you for your time in advance!

It's best to start a discussion with the Q&A topic for that. I will answer it there, for this PR it's a bit off-topic :)

@evroon
Copy link
Owner

evroon commented May 8, 2025

Thanks for the fix, I think it looks good! There was a reason I disabled the player names in the past, not sure why anymore, probably because I temporarily excluded them from the backend response to make the endpoint simpler/faster, but that's not necessary anymore.

@evroon evroon merged commit ec8addc into evroon:master May 8, 2025
3 of 4 checks passed
@jmillxyz jmillxyz deleted the team-members branch May 12, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants