Skip to content

add missing locale #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Conversation

nvanheuverzwijn
Copy link
Contributor

I was wondering why these locale were not added in the project. Adding them make the language configuration UI works properly with missing languages. Right now, if you set french or italian, it does not work. With this patch, everything works out.

Copy link

vercel bot commented Apr 3, 2025

@nvanheuverzwijn is attempting to deploy a commit to the evroon's projects Team on Vercel.

A member of the Team first needs to authorize it.

@nvanheuverzwijn
Copy link
Contributor Author

@evroon I would also make the default locale a runtime replaced environment variable so we can set the default language to whatever our locale is.

Copy link
Owner

@evroon evroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks

Hmm yes an environment variable should be doable, could you create an issue?

@evroon evroon merged commit 34612dc into evroon:master Apr 3, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants