Files that changed from the base of the PR and between c1b2b6a and 6c6864e.

• api/ethermint/evm/v1/query_grpc.pb.go is excluded by !**/*.pb.go
• x/evm/types/query.pb.go is excluded by !**/*.pb.go
• x/evm/types/query.pb.gw.go is excluded by !**/*.pb.gw.go

• CHANGELOG.md (1 hunks)
• api/ethermint/evm/v1/query.pulsar.go (6 hunks)
• client/docs/swagger-ui/swagger.json (166 hunks)
• proto/ethermint/evm/v1/query.proto (2 hunks)
• proto/ethermint/feemarket/v1/feemarket.proto (1 hunks)
• proto/ethermint/types/v1/dynamic_fee.proto (1 hunks)
• rpc/backend/backend.go (2 hunks)
• rpc/backend/call_tx.go (1 hunks)
• rpc/backend/call_tx_test.go (1 hunks)
• rpc/backend/chain_info.go (1 hunks)
• rpc/backend/chain_info_test.go (1 hunks)
• rpc/backend/evm_query_client_test.go (1 hunks)
• rpc/backend/mocks/evm_query_client.go (1 hunks)
• rpc/backend/node_info.go (3 hunks)
• rpc/backend/node_info_test.go (1 hunks)
• x/evm/keeper/grpc_query.go (1 hunks)
• x/evm/types/scaling.go (1 hunks)
• x/evm/types/scaling_test.go (1 hunks)

• api/ethermint/evm/v1/query.pulsar.go: Error: Server error: no LLM provider could handle the message

• client/docs/swagger-ui/swagger.json
• proto/ethermint/feemarket/v1/feemarket.proto
• proto/ethermint/types/v1/dynamic_fee.proto

x/evm/types/scaling.go (1)

Line range hint 1-42: Summary of changes and impact

The addition of the ConvertBigIntFrom18DecimalsToLegacyDec function enhances the scaling capabilities of the module by providing a way to convert from 18 decimals to the EVM coin's decimal representation. This change aligns well with the PR objective of refactoring RPC gas prices to support 6 decimal places.

The new function complements the existing ConvertAmountTo18DecimalsLegacy function, providing a reverse operation. It maintains the flexibility to work with different decimal configurations as determined by GetEVMCoinDecimals().

Overall, this change improves the module's ability to handle various decimal representations, which is crucial for accurate gas price calculations and conversions in the EVM context.

rpc/backend/backend.go (3)

51-51: Overall impact of gas price refactoring

The changes to RPCMinGasPrice and GlobalMinGasPrice methods consistently use *big.Int for gas price representation, which aligns with the PR objective to "refactor rpc gas prices to support 6 dec". This refactoring allows for more precise gas price handling, supporting up to 6 decimal places as mentioned in the PR title.

Given the significance of these changes:

1. Ensure comprehensive unit and integration tests are in place to verify the correct behavior of gas price calculations and representations throughout the system.
2. Update any documentation, including API docs and developer guides, to reflect these changes.
3. Consider adding a migration guide if this change affects external integrations or APIs.

To ensure a smooth transition, run the following script to identify potential areas that might need updates:

#!/bin/bash
# Description: Identify potential areas affected by the gas price refactoring

# Test: Search for usages of int64 or math.LegacyDec in relation to gas prices
echo "Searching for potential areas that might need updates:"
rg --type go -e '(int64|math\.LegacyDec).*gas.*price'

# Test: Search for any remaining usages of math.LegacyDec
echo "Searching for any remaining usages of math.LegacyDec:"
rg --type go -e 'math\.LegacyDec'

Please review the output of this script to ensure all relevant areas have been updated to use *big.Int for gas price representation.

Also applies to: 86-86

---

86-86: Approve change to GlobalMinGasPrice return type.

The modification of the return type from (math.LegacyDec, error) to (*big.Int, error) for GlobalMinGasPrice is a good improvement. This change aligns with the RPCMinGasPrice method, standardizing on *big.Int for gas price representation.

Please ensure that all implementations of this interface method and any code that calls this method have been updated accordingly. Run the following script to verify the usage:

Consider updating the documentation to reflect this change in return type, especially if there are any API docs or developer guides that mention the GlobalMinGasPrice method.

✅ Verification successful

Change to GlobalMinGasPrice return type verified.

The update of GlobalMinGasPrice to return (*big.Int, error) has been successfully verified with no existing implementations or usages conflicting with this change. This ensures that the modification aligns with the intended standardization without introducing issues.

Consider updating the documentation to reflect this change in return type, ensuring that all relevant API docs and developer guides are consistent with the new method signature.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all implementations and usages of GlobalMinGasPrice method

# Test: Search for GlobalMinGasPrice method implementations
echo "Searching for GlobalMinGasPrice implementations:"
rg --type go -e 'func \(.*\) GlobalMinGasPrice\(\) \(\*big\.Int, error\)'

# Test: Search for GlobalMinGasPrice method calls
echo "Searching for GlobalMinGasPrice method calls:"
rg --type go -e 'GlobalMinGasPrice\(\)'

Length of output: 10966

---

51-51: Approve change to RPCMinGasPrice return type.

The modification of the return type from int64 to *big.Int for RPCMinGasPrice is a good improvement. This change allows for more precise representation of gas prices and can handle arbitrarily large values, which is beneficial for cryptocurrency applications.

Please ensure that all implementations of this interface method and any code that calls this method have been updated accordingly. Run the following script to verify the usage:

✅ Verification successful

RPCMinGasPrice Return Type Updated Correctly

The return type of RPCMinGasPrice has been successfully updated to *big.Int across all implementations and usages. All assignments and operations involving this method handle the *big.Int type appropriately, ensuring type safety and correctness.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all implementations and usages of RPCMinGasPrice method

# Test: Search for RPCMinGasPrice method implementations
echo "Searching for RPCMinGasPrice implementations:"
rg --type go -e 'func \(.*\) RPCMinGasPrice\(\) \*big\.Int'

# Test: Search for RPCMinGasPrice method calls
echo "Searching for RPCMinGasPrice method calls:"
rg --type go -e 'RPCMinGasPrice\(\)'

Length of output: 701

---

Script:

#!/bin/bash
# Description: Verify handling of RPCMinGasPrice return type in all usage locations

# Function to check usage in a specific file
check_usage() {
  local file=$1
  echo "Checking RPCMinGasPrice usage in $file:"

  # Check for correct type handling (expecting *big.Int)
  rg --type go -A 5 'RPCMinGasPrice\(\)' "$file" | grep -E '(*big\.Int)|(&big\.Int)|big\.NewInt'
  
  echo ""
}

# List of files with RPCMinGasPrice calls
files=(
  "rpc/backend/node_info_test.go"
  "rpc/backend/node_info.go"
  "rpc/backend/call_tx.go"
  "rpc/backend/backend.go"
)

for file in "${files[@]}"; do
  check_usage "$file"
done

Length of output: 1810

---

Script:

#!/bin/bash
# Description: Verify handling of RPCMinGasPrice return type in all usage locations with corrected regex

# Function to check usage in a specific file
check_usage() {
  local file=$1
  echo "Checking RPCMinGasPrice usage in $file:"

  # Corrected regex patterns to match literal *big.Int, &big.Int, or big.NewInt
  rg --type go -A 5 'RPCMinGasPrice\(\)' "$file" | grep -E '(\*big\.Int)|(&big\.Int)|big\.NewInt'
  
  echo ""
}

# List of files with RPCMinGasPrice calls
files=(
  "rpc/backend/node_info_test.go"
  "rpc/backend/node_info.go"
  "rpc/backend/call_tx.go"
  "rpc/backend/backend.go"
)

for file in "${files[@]}"; do
  check_usage "$file"
done

Length of output: 1654

---

Script:

#!/bin/bash
# Description: Inspect usage of RPCMinGasPrice return type in all usage locations

# Function to analyze how RPCMinGasPrice is used in a specific file
analyze_usage() {
  local file=$1
  echo "Analyzing RPCMinGasPrice usage in $file:"
  
  # Extract lines where RPCMinGasPrice is called along with surrounding context
  rg --type go -C 3 'RPCMinGasPrice\(\)' "$file" | while read -r line; do
    echo "$line"
  done
  
  echo ""
}

# List of files with RPCMinGasPrice calls
files=(
  "rpc/backend/node_info_test.go"
  "rpc/backend/node_info.go"
  "rpc/backend/call_tx.go"
  "rpc/backend/backend.go"
)

for file in "${files[@]}"; do
  analyze_usage "$file"
done

Length of output: 4667

rpc/backend/node_info_test.go (1)

Line range hint 1-1: Summary of changes in rpc/backend/node_info_test.go

The changes made to this file are appropriate and align with the PR objective of supporting 6 decimal places for gas prices. The modifications are localized to the TestRPCMinGasPrice function, changing the expMinGasPrice field from int64 to *big.Int. This change allows for higher precision in gas price representation.

Key points:

1. The change is minimal and doesn't affect other test functions in this file.
2. The use of big.NewInt(types.DefaultGasPrice) ensures consistency with the new data type.
3. A suggestion was made to add a comment explaining the reason for using *big.Int.
4. A verification script was provided to check for any inconsistencies in gas price type usage across the codebase.

Overall, the changes look good, but it's important to ensure that this modification is consistent with the rest of the codebase and doesn't introduce any unexpected behavior in other components that might be expecting int64 gas prices.

x/evm/types/scaling_test.go (2)

272-323: Well-structured and comprehensive test function.

The TestConvertBigIntFrom18DecimalsToLegacyDec function is well-designed and covers a good range of test cases. It tests the conversion functionality for both 6 and 18 decimal configurations, which aligns well with the PR objective of supporting 6 decimal places.

Some noteworthy aspects:

1. The test cases cover important scenarios such as the smallest amount, values close to 1, and larger values like "one ether".
2. The function tests both 6 and 18 decimal configurations, ensuring compatibility with different setups.
3. The use of evmtypes.NewEVMConfigurator() for each test case ensures a clean environment for each test.

---

272-323: Overall, the new test function enhances the test coverage significantly.

The addition of TestConvertBigIntFrom18DecimalsToLegacyDec is a valuable contribution to the test suite. It directly supports the PR's objective of refactoring RPC gas prices to support 6 decimal places by thoroughly testing the conversion function for both 6 and 18 decimal configurations.

The test cases are well-chosen and cover a good range of scenarios. The structure of the test function, with its nested loops for different configurations, ensures comprehensive coverage.

This new test function will help maintain the reliability of the conversion logic as the codebase evolves, which is crucial for accurate gas price handling in both 6 and 18 decimal scenarios.

rpc/backend/chain_info_test.go (1)

Line range hint 1-465: Overall assessment of changes

The modifications to the TestGlobalMinGasPrice function align well with the PR objective of refactoring RPC gas prices to support 6 decimal places. The switch from math.LegacyDec to *big.Int allows for more precise representation of gas prices.

However, to ensure robustness and complete coverage of the new functionality:

1. Consider expanding the test cases as suggested in the previous comment.
2. Review other parts of the codebase that might be affected by this change, especially any code that interacts with GlobalMinGasPrice.
3. Ensure that the precision of 6 decimal places is consistently maintained and verified throughout the relevant parts of the codebase.

To ensure consistency across the codebase, let's check for other files that might need similar updates:

#!/bin/bash
# Search for files using math.LegacyDec in relation to gas prices
rg "math\.LegacyDec.*gas.*price" --type go

# Search for files using GlobalMinGasPrice
rg "GlobalMinGasPrice" --type go

This will help identify any other areas that might need attention due to this refactoring.

proto/ethermint/evm/v1/query.proto (2)

322-323: LGTM: QueryGlobalMinGasPriceRequest is correctly defined.

The empty QueryGlobalMinGasPriceRequest message is appropriate for this query, as it doesn't require any input parameters. This approach is consistent with similar request messages in the file.

---

Line range hint 80-329: Summary: Changes are well-implemented and align with PR objectives.

The new GlobalMinGasPrice RPC method and associated request/response messages have been correctly implemented. They are consistent with the existing code structure and follow appropriate protobuf conventions. The changes support the PR objective of refactoring RPC gas prices to accommodate six decimal places.

A few minor suggestions were made to improve comment clarity, but overall, the implementation is sound and ready for integration.

rpc/backend/evm_query_client_test.go (1)

278-283: Overall changes look good and maintain code consistency.

The addition of the RegisterGlobalMinGasPrice function at the end of the file and the extra newline maintain the existing code structure and improve readability. These changes are consistent with the file's organization and coding style.

rpc/backend/call_tx.go (2)

401-402: Ensure precision is maintained in gas price comparison

The simplified comparison result.Cmp(minGasPrice) < 0 assumes that minGasPrice is now of type *big.Int. Please verify that this change doesn't affect the precision of the gas price calculation, especially if minGasPrice was previously of a different type (e.g., sdk.Dec).

#!/bin/bash
# Search for the definition of GlobalMinGasPrice to verify its return type
rg --type go "func.*GlobalMinGasPrice.*\) \*big\.Int" .

Consider adding a comment explaining the reasoning behind this simplified comparison and any potential implications on gas price precision.

---

393-393: Verify return type of b.RPCMinGasPrice()

The direct assignment result = b.RPCMinGasPrice() assumes that b.RPCMinGasPrice() returns a *big.Int. Please verify that this is indeed the case to ensure type compatibility.

Consider adding a comment explaining why this direct assignment is preferred over creating a new big.Int.

rpc/backend/mocks/evm_query_client.go (1)

242-270: LGTM: New GlobalMinGasPrice method added correctly

The new GlobalMinGasPrice method has been implemented correctly following the established pattern for mock methods in this file. It properly handles the input parameters and return values, maintaining consistency with other methods.

x/evm/keeper/grpc_query.go (1)

711-717: Implementation looks good, but consider adding documentation and verifying truncation.

The GlobalMinGasPrice method is implemented correctly and follows the expected pattern for gRPC query methods. However, I have a few suggestions for improvement:

1. Consider adding a comment block above the method to explain its purpose and behavior. This will improve code readability and maintainability.

2. The truncation of the minimum gas price to an integer (line 715) might lead to loss of precision. Please verify if this is the intended behavior. If precision is important, you might want to return the full decimal value instead.

Here's a suggested improvement with added documentation:

+// GlobalMinGasPrice implements the Query/GlobalMinGasPrice gRPC method.
+// It returns the global minimum gas price as an integer.
+// Note: The returned value is truncated, which may lead to loss of precision.
 func (k Keeper) GlobalMinGasPrice(c context.Context, _ *types.QueryGlobalMinGasPriceRequest) (*types.QueryGlobalMinGasPriceResponse, error) {
 	ctx := sdk.UnwrapSDKContext(c)
 	minGasPrice := k.GetMinGasPrice(ctx).TruncateInt()
 	return &types.QueryGlobalMinGasPriceResponse{MinGasPrice: minGasPrice}, nil
 }

To verify the intentional truncation of the gas price and its potential impact, we can run the following script:

This script will help us understand if the truncation is consistent with other parts of the codebase and if there's any documentation about the precision of the minimum gas price.

CHANGELOG.md (3)

Line range hint 43-44: Notable Improvements

1. Enhanced testing: Lint tests, new e2e tests, and improved integration test utils.
2. CI improvements: Added Golang dependency vulnerability checker.
3. Documentation updates: Added audits page and improved existing docs.
4. Module refactoring: vesting, ERC-20, and outpost modules have been improved.
5. Performance enhancements: Improved efficiency in various modules.

These improvements should lead to better code quality, security, and developer experience. Ensure that:

1. The new tests are comprehensive and cover critical paths.
2. The vulnerability checker is properly configured and integrated into the CI pipeline.
3. Documentation accurately reflects the latest changes and new features.

Also applies to: 45-46, 47-48, 49-50, 51-52, 53-54, 55-56, 57-58, 59-60, 61-62, 63-64, 65-66, 67-68, 69-70

🧰 Tools

🪛 Markdownlint

68-68: Expected: 120; Actual: 150
Line length

(MD013, line-length)

---

71-71: New feature: Refactor JSON-RPC gas prices

This change could have significant implications for users interacting with the JSON-RPC interface. It's important to ensure that this refactoring doesn't break existing integrations.

To verify the impact of this change, we should run the following script:

✅ Verification successful

Verified: No changes found in GasPrice functions.

The refactor does not modify any GasPrice-related functions, ensuring existing JSON-RPC integrations remain unaffected.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any changes in gas price related functions
rg --type go 'func.*GasPrice'

Length of output: 13806

---

Script:

#!/bin/bash
# Search for any function definitions or modifications related to GasPrice using ast-grep
ast-grep --lang go --pattern 'func GasPrice($_)' .

Length of output: 52

---

72-73: Critical Bug Fixes

Several important bugs have been addressed:

1. Fixed Ledger support for EthSecp256k1.
2. Corrected snapshot configuration and CLI version output.
3. Fixed setup of gRPC node service.
4. Resolved issues with unbound metrics.
5. Fixed the problem of users unable to send transactions with 0 gasPrice to precompiled contracts.

These fixes should significantly improve the stability and usability of the system. Ensure that:

1. Regression tests are added for each of these bug fixes to prevent future recurrence.
2. The fixes are well-documented, especially those affecting user interactions like the gasPrice issue.

To verify the impact of these bug fixes, run the following script:

Also applies to: 74-75, 76-77, 78-79, 80-81, 82-83

api/ethermint/evm/v1/query.pulsar.go (6)

11962-12316: LGTM: New QueryGlobalMinGasPriceRequest structures and methods added correctly.

The new code for QueryGlobalMinGasPriceRequest has been properly integrated into the file. It follows the standard pattern for protocol buffer generated code, including all necessary reflection-related methods and structures.

---

12317-12737: LGTM: QueryGlobalMinGasPriceResponse correctly implemented.

The QueryGlobalMinGasPriceResponse structure and its associated methods have been properly implemented. The MinGasPrice field is correctly defined as a string type and is handled appropriately in all generated methods. The code adheres to the standard protocol buffer generated code pattern.

---

13892-13954: LGTM: QueryGlobalMinGasPrice request and response structs properly defined.

The QueryGlobalMinGasPriceRequest and QueryGlobalMinGasPriceResponse structs are correctly defined with their associated methods. The MinGasPrice field in the response struct is properly typed as a string. All necessary Go struct methods (Reset, String, ProtoMessage, etc.) are present and correctly implemented.

---

14288-14336: LGTM: Message types correctly updated for GlobalMinGasPrice query.

The file_ethermint_evm_v1_query_proto_msgTypes and file_ethermint_evm_v1_query_proto_goTypes slices have been properly updated to include the new QueryGlobalMinGasPriceRequest and QueryGlobalMinGasPriceResponse types. The additions are consistent with the existing pattern and indices in the file.

---

Line range hint 14349-14689: LGTM: Dependency indices and exporters correctly updated for GlobalMinGasPrice.

The file_ethermint_evm_v1_query_proto_depIdxs slice has been properly updated to include the new GlobalMinGasPrice query method. The exporter functions for QueryGlobalMinGasPriceRequest and QueryGlobalMinGasPriceResponse have been correctly implemented. These changes are consistent with the existing pattern in the file.

---

Line range hint 11962-14697: LGTM: GlobalMinGasPrice query successfully integrated.

The new GlobalMinGasPrice query has been successfully integrated into the generated protocol buffer code. All necessary structures, methods, and type information have been correctly added and are consistent with the existing codebase.

However, as this is generated code, it's important to ensure that the actual implementation of the GlobalMinGasPrice query is correctly handled in the corresponding service files.

To verify the complete implementation, please check the following:

rpc/backend/chain_info.go (1)

50-55: Ensure all callers of GlobalMinGasPrice handle the new return type

The return type of GlobalMinGasPrice has been changed from math.LegacyDec to *big.Int. Please verify that all code invoking this method has been updated accordingly to handle the new return type, preventing any potential runtime errors or type mismatches.

Run the following script to find all usages of GlobalMinGasPrice in the codebase:

rpc/backend/node_info.go (2)

290-294: Correctly scales gas price to denomination precision

The gas price is properly converted from 18 decimals to the denomination's precision using ConvertBigIntFrom18DecimalsToLegacyDec, ensuring accurate fee calculations.

---

341-350: Properly updates RPCMinGasPrice to return *big.Int

The method RPCMinGasPrice now correctly returns a *big.Int, converting the minimum gas price to 18-decimal precision. This change enhances compatibility with Ethereum clients that expect gas prices in 18-decimal format.

Files that changed from the base of the PR and between 6c6864e and 88aeefb.

• rpc/backend/chain_info.go (1 hunks)

rpc/backend/chain_info.go (1)

55-58: Add a nil check for res.MinGasPrice before calling BigInt()

To prevent a potential nil pointer dereference, ensure that res.MinGasPrice is not nil before calling res.MinGasPrice.BigInt().

Files that changed from the base of the PR and between 25b9986 and c977de1.

• CHANGELOG.md (1 hunks)

CHANGELOG.md (3)

72-73: New feature: JSON-RPC gas prices support for different precision

This improvement adds support for JSON-RPC gas prices with different precision. This could have significant implications for how gas prices are handled and may require updates to client applications interacting with the JSON-RPC interface.

---

Line range hint 34-35: Various improvements and bug fixes

This release includes several improvements and bug fixes:

1. Performance improvements for eth_headerByHash
2. Updates to the Interpreter interface to support custom Opcodes
3. Fix for the community pool being nil
4. Updates to CLI commands and removal of unnecessary fee ante handlers
5. Changes to how the ChainID is handled in the EVM module
6. Adjustments to extra decimals handling in EVM state operations

These changes should enhance the overall performance and functionality of the system. However, developers should review these changes to ensure compatibility with their applications, especially those interacting with the EVM module or using the CLI commands.

Also applies to: 36-37, 38-39, 40-41, 42-43, 44-45, 46-47, 48-49, 50-51, 52-53, 54-55, 56-57, 58-59, 60-61, 62-63, 64-65, 66-67, 68-69, 70-71

🧰 Tools

🪛 Markdownlint

69-69: Expected: 120; Actual: 150
Line length

(MD013, line-length)

---

Line range hint 1-2147: Well-structured and informative changelog

The CHANGELOG.md file is well-organized and provides a detailed history of changes across multiple versions of the Evmos project. It consistently categorizes changes into State Machine Breaking, API Breaking, Improvements, and Bug Fixes, which is helpful for users and developers to understand the impact of each release.

For future updates, consider adding more context or rationale for major changes, especially those that are state machine breaking. This could help users and developers better understand the motivations behind significant changes and prepare for upgrades more effectively.

🧰 Tools

🪛 Markdownlint

69-69: Expected: 120; Actual: 150
Line length

(MD013, line-length)