Skip to content

feat(gov-precompile): Added getDeposit, getDeposits and getTallyResults queries, unit and integration tests. (backport #2941) #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat(gov-precompile): Added getDeposit, getDeposits and getTallyResults queries, unit and integration tests. (backport #2941) #2947

merged 3 commits into from
Oct 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 20, 2024

Description

This PR adds the 3 high priority queries from the list of missing precompiles. There is one TODO left that I couldn't get to work in the integration tests without implementing the deposit transaction as a precompile transaction. Maybe there is a workaround ?

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

Summary by CodeRabbit

  • New Features

    • Enhanced governance interface with new structures for managing deposits and tally results.
    • Added functions to retrieve deposit information and tally results for governance proposals.

  • Bug Fixes

    • Introduced error handling for invalid depositors.

  • Tests

    • Added new integration and unit tests to validate the functionality of the newly implemented methods.

  • Documentation

    • Updated ABI to reflect new functions for improved governance management.
    • Updated CHANGELOG to include significant modifications and improvements.
This is an automatic backport of pull request #2941 done by [Mergify](https://mergify.com).

@Vvaradinov @mergify
feat(gov-precompile): Added getDeposit, getDeposits and getTallyResul…
4165955 
…ts queries, unit and integration tests. (#2941)

* feat: add getDeposit, getDeposits and getTallyResults

* feat: add the queries, types, unit and integration tests

* run make format

* format and lint

* tests: address comments from code review

* fix: json linter

* Update precompiles/gov/integration_test.go

Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>

* use const for denom in test

* chore: add changelog entry

* Update precompiles/gov/IGov.sol

Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
Signed-off-by: Guillermo Paoletti <guillermo.paoletti@gmail.com>

* refactor prop msgs

---------

Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>
Signed-off-by: Guillermo Paoletti <guillermo.paoletti@gmail.com>
Co-authored-by: Vvaradinov <Vvaradinov@users.noreply.github.com>
Co-authored-by: hanchon <guillermo.paoletti@gmail.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
(cherry picked from commit cb53cf0)

# Conflicts:
#	.golangci.yml
#	CHANGELOG.md
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Oct 20, 2024

Cherry-pick of cb53cf0 has failed:

On branch mergify/bp/rama/release-v20/pr-2941
Your branch is up to date with 'origin/rama/release-v20'.

You are currently cherry-picking commit cb53cf0a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/e2e-test.yml
	modified:   precompiles/gov/IGov.sol
	modified:   precompiles/gov/abi.json
	modified:   precompiles/gov/errors.go
	modified:   precompiles/gov/gov.go
	modified:   precompiles/gov/integration_test.go
	modified:   precompiles/gov/query.go
	modified:   precompiles/gov/query_test.go
	modified:   precompiles/gov/setup_test.go
	modified:   precompiles/gov/types.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .golangci.yml
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team as a code owner October 20, 2024 09:33
@mergify mergify bot added the conflicts label Oct 20, 2024
@mergify mergify bot requested review from ramacarlucho and MalteHerrmann and removed request for a team October 20, 2024 09:33
@mergify mergify bot mentioned this pull request Oct 20, 2024
Merged
9 tasks
@GAtom22 GAtom22 merged commit f098677 into rama/release-v20 Oct 21, 2024
19 of 22 checks passed
@GAtom22 GAtom22 deleted the mergify/bp/rama/release-v20/pr-2941 branch October 21, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramacarlucho ramacarlucho Awaiting requested review from ramacarlucho ramacarlucho is a code owner automatically assigned from evmos/core-engineering

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

2 more reviewers

@hanchon hanchon hanchon approved these changes

@GAtom22 GAtom22 GAtom22 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CI conflicts precompile tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanchon @GAtom22 @Vvaradinov