feat(precompile): add gov precompile (vote only) (backport #2858) #2859

mergify · 2024-09-18T13:38:35Z

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

tackled an existing issue or discussed with a team member
left instructions on how to review the changes
targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

added a relevant changelog entry to the Unreleased section in CHANGELOG.md
confirmed all author checklist items have been addressed
confirmed that this PR does not change production code
reviewed content
tested instructions (if applicable)
confirmed all CI checks have passed

Summary by CodeRabbit

New Features
- Introduced a governance precompile feature for voting transactions, enhancing user participation in governance activities.
- Added an interface for governance proposals, including voting options and event logging.
- Implemented functions for querying votes and handling voting messages, improving event tracking and management.
- Added a new global variable for the governance precompile address, streamlining interactions with governance-related smart contracts.
Bug Fixes
- Removed automatic withdrawal of staking rewards under specific conditions.
Documentation
- Updated changelog to reflect recent changes and enhancements.
Tests
- Added comprehensive test suites for governance voting functionality and event emissions.
- Included integration tests for validating vote transactions and query capabilities.

This is an automatic backport of pull request #2858 done by [Mergify](https://mergify.com).

* feat(precompile): add gov precompile (vote only) * run make format * add changelog entry * fix linter * fix event parsing * minor fix * remove unused * feat: add votes query for a single proposal * feat: add single voter vote request * run make format * fix: remove comments * fix * apply review comments * refactor events * Update precompiles/gov/query.go Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com> * fix conflict * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com> * small refactor * add invalid vote option test * run make format * add getVote in Run func * run make format * add comments * Update CHANGELOG.md Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com> * fix compilation * fix error * fix test * fix queries unit tests * add queries integration tests * fix changelog * Update CHANGELOG.md Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com> --------- Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: GAtom22 <GAtom22@users.noreply.github.com> Co-authored-by: stepit <stefanofrancesco.pitton@gmail.com> Co-authored-by: Vlad <vladislav.varadinov@gmail.com> Co-authored-by: Vvaradinov <Vvaradinov@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 4c59847) # Conflicts: # CHANGELOG.md

mergify · 2024-09-18T13:38:37Z

Cherry-pick of 4c59847 has failed:

On branch mergify/bp/rama/release-v20/pr-2858
Your branch is up to date with 'origin/rama/release-v20'.

You are currently cherry-picking commit 4c59847b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   app/app.go
	new file:   precompiles/gov/IGov.sol
	new file:   precompiles/gov/abi.json
	new file:   precompiles/gov/errors.go
	new file:   precompiles/gov/events.go
	new file:   precompiles/gov/events_test.go
	new file:   precompiles/gov/gov.go
	new file:   precompiles/gov/gov_test.go
	new file:   precompiles/gov/integration_test.go
	new file:   precompiles/gov/query.go
	new file:   precompiles/gov/query_test.go
	new file:   precompiles/gov/setup_test.go
	new file:   precompiles/gov/tx.go
	new file:   precompiles/gov/tx_test.go
	new file:   precompiles/gov/types.go
	modified:   x/evm/keeper/static_precompiles.go
	modified:   x/evm/types/params.go
	modified:   x/evm/types/precompiles.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

coderabbitai · 2024-09-18T13:38:42Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai generate interesting stats about this repository and render them as a table.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mergify bot requested a review from a team as a code owner September 18, 2024 13:38

mergify bot added the conflicts label Sep 18, 2024

mergify bot requested review from Vvaradinov and 0xstepit and removed request for a team September 18, 2024 13:38

mergify bot mentioned this pull request Sep 18, 2024

feat(precompile): add gov precompile (vote only) #2858

Merged

9 tasks

github-actions bot added tests precompile labels Sep 18, 2024

GAtom22 added 4 commits September 18, 2024 10:43

fix chlog

f5b4e44

fix chlog

95dfc4e

fix chlog

e4b9960

add utils func used in gov tests

6b9350f

GAtom22 approved these changes Sep 18, 2024

View reviewed changes

GAtom22 merged commit 74bf6f5 into rama/release-v20 Sep 18, 2024
19 of 22 checks passed

GAtom22 deleted the mergify/bp/rama/release-v20/pr-2858 branch September 18, 2024 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(precompile): add gov precompile (vote only) (backport #2858) #2859

feat(precompile): add gov precompile (vote only) (backport #2858) #2859

Uh oh!

mergify bot commented Sep 18, 2024

Uh oh!

mergify bot commented Sep 18, 2024

Uh oh!

coderabbitai bot commented Sep 18, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

feat(precompile): add gov precompile (vote only) (backport #2858) #2859

feat(precompile): add gov precompile (vote only) (backport #2858) #2859

Uh oh!

Conversation

mergify bot commented Sep 18, 2024

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

Uh oh!

mergify bot commented Sep 18, 2024

Uh oh!

coderabbitai bot commented Sep 18, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)