Skip to content

chore(go-lint): fix linter errors (backport #2764) #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2024
Merged

chore(go-lint): fix linter errors (backport #2764) #2789

merged 5 commits into from
Aug 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 28, 2024

Description

The golangci-lint version was bumped to v1.60.1. Now we have new linter errors.
This PR addresses those

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

Summary by CodeRabbit

  • New Features

    • Enhanced clarity of error messages throughout the application, providing more context for debugging.
    • Improved consistency in error reporting by standardizing the method of error message creation.

  • Bug Fixes

    • Adjustments to error handling mechanisms that simplify the error creation process.

These changes improve user experience by making errors more understandable and facilitating easier debugging.

This is an automatic backport of pull request #2764 done by [Mergify](https://mergify.com).

@GAtom22 @mergify
chore(go-lint): fix linter errors (#2764)
d5accc0 
* fix linter errors

* Apply suggestions from code review

Signed-off-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

---------

Signed-off-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 8ad527d)

# Conflicts:
#	app/ante/cosmos/authz.go
#	app/tps_counter_test.go
#	ibc/utils.go
#	precompiles/authorization/types.go
#	precompiles/common/precompile.go
#	precompiles/erc20/tx.go
#	precompiles/ics20/types.go
#	precompiles/staking/tx.go
#	precompiles/testutil/logs.go
#	tests/e2e/upgrade/manager.go
#	testutil/abci.go
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 28, 2024

Cherry-pick of 8ad527d has failed:

On branch mergify/bp/release/v20.0.x/pr-2764
Your branch is up to date with 'origin/release/v20.0.x'.

You are currently cherry-picking commit 8ad527d9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   app/ante/cosmos/authz.go
	both modified:   app/tps_counter_test.go
	both modified:   ibc/utils.go
	both modified:   precompiles/authorization/types.go
	both modified:   precompiles/common/precompile.go
	both modified:   precompiles/erc20/tx.go
	both modified:   precompiles/ics20/types.go
	both modified:   precompiles/staking/tx.go
	both modified:   precompiles/testutil/logs.go
	both modified:   tests/e2e/upgrade/manager.go
	both modified:   testutil/abci.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team as a code owner August 28, 2024 10:55
@mergify mergify bot added the conflicts label Aug 28, 2024
@mergify mergify bot requested review from 0xstepit and GAtom22 August 28, 2024 10:55
@mergify mergify bot mentioned this pull request Aug 28, 2024
Merged
9 tasks
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Vvaradinov Vvaradinov merged commit 7179d81 into release/v20.0.x Aug 28, 2024
46 of 50 checks passed
@Vvaradinov Vvaradinov deleted the mergify/bp/release/v20.0.x/pr-2764 branch August 28, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GAtom22 GAtom22 Awaiting requested review from GAtom22 GAtom22 was automatically assigned from evmos/core-engineering

2 more reviewers

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@0xstepit 0xstepit 0xstepit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
precompile release tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vvaradinov @0xstepit @dev-evmos @GAtom22