chore(deps): bump sdk to v0.50 & IBC to v8 #2771

GAtom22 · 2024-08-19T16:12:40Z

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

tackled an existing issue or discussed with a team member
left instructions on how to review the changes
targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

added a relevant changelog entry to the Unreleased section in CHANGELOG.md
confirmed all author checklist items have been addressed
confirmed that this PR does not change production code
reviewed content
tested instructions (if applicable)
confirmed all CI checks have passed

Summary by CodeRabbit

New Features
- Enhanced GitHub Actions workflows for improved code formatting and testing.
- Added support for dynamic fee transactions and access lists in the Ethereum-compatible framework.
- Introduced epoch management features for better tracking of blockchain states.
- Implemented ERC20 module functionalities, including token conversions and precompile configurations.
- Added a function to extract signers from Ethereum transaction signatures for ERC20 messages.
- Updated dependencies for Cosmos-SDK and IBC-Go to enhance functionality and fix issues.
- Added a withdrawer address check in transactions for improved transaction handling.
- Introduced an upgrade handler for version 19 and the EditValidator function for staking.
- Removed deprecated types and modules to streamline code practices.
Bug Fixes
- Adjusted parameters for various workflows to optimize performance and reliability.
Documentation
- Updated README and CHANGELOG for better clarity on recent changes and career opportunities.
Chores
- Refined configuration files for linter and formatting tools to improve code quality and maintainability.

coderabbitai

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (9)

CHANGELOG.md (9)

Line range hint 58-58: Improve clarity and consistency in descriptions.

Consider revising the descriptions in the "Improvements" section to ensure they are clear and consistent. This will help readers understand the changes more effectively.

Tools

Markdownlint

43-43: Expected: 120; Actual: 171
Line length

(MD013, line-length)

90-90: Add more details to bug fix descriptions.

Consider adding more details to the descriptions of the bug fixes listed in this section. This will help readers understand the context and impact of the fixes.

387-387: Add more details to bug fix descriptions.

Consider adding more details to the descriptions of the bug fixes listed in this section. This will help readers understand the context and impact of the fixes.

Tools

Markdownlint

387-387: Expected: 120; Actual: 151
Line length

(MD013, line-length)

655-655: Improve clarity and consistency in descriptions.

Consider revising the descriptions in the "Improvements" section to ensure they are clear and consistent. This will help readers understand the changes more effectively.

Tools

Markdownlint

655-655: Expected: 120; Actual: 230
Line length

(MD013, line-length)

655-655: Add more details to bug fix descriptions.

Consider adding more details to the descriptions of the bug fixes listed in this section. This will help readers understand the context and impact of the fixes.

Tools

Markdownlint

655-655: Expected: 120; Actual: 230
Line length

(MD013, line-length)

808-808: Improve clarity and consistency in descriptions.

Consider revising the descriptions in the "Improvements" section to ensure they are clear and consistent. This will help readers understand the changes more effectively.

808-808: Add more details to bug fix descriptions.

Consider adding more details to the descriptions of the bug fixes listed in this section. This will help readers understand the context and impact of the fixes.

1018-1018: Improve clarity and consistency in descriptions.

Consider revising the descriptions in the "Improvements" section to ensure they are clear and consistent. This will help readers understand the changes more effectively.

1018-1018: Add more details to bug fix descriptions.

Consider adding more details to the descriptions of the bug fixes listed in this section. This will help readers understand the context and impact of the fixes.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7e73abc and fbabf9b.

Files selected for processing (1)

CHANGELOG.md (13 hunks)

Additional context used

Markdownlint

CHANGELOG.md

91-91: Expected: 120; Actual: 128
Line length

(MD013, line-length)

387-387: Expected: 120; Actual: 151
Line length

(MD013, line-length)

655-655: Expected: 120; Actual: 230
Line length

(MD013, line-length)

1085-1085: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

Additional comments not posted (5)

CHANGELOG.md (5)
42-42: Verify pull request links and descriptions.

Please ensure that all links to pull requests are active and the descriptions accurately reflect the changes made. This is crucial for maintaining accurate documentation in the changelog.

402-402: Verify completeness and accuracy of entries.

Please ensure that all state machine breaking changes listed in the v16.0.0 release are documented completely and accurately. This is crucial for users upgrading to this version.

358-358: Verify completeness and accuracy of entries.

Please ensure that all state machine breaking changes listed in the v19.0.0 release are documented completely and accurately. This is crucial for users upgrading to this version.

1018-1018: Verify completeness and accuracy of entries.

Please ensure that all state machine breaking changes listed in the v10.0.0 release are documented completely and accurately. This is crucial for users upgrading to this version.

Verification successful

Changelog entry is accurate and complete.

The changelog entry regarding the addition of the IBC-Go TestingApp interface is accurate and corresponds to actual changes in the codebase. The TestingApp interface is well-documented and implemented across multiple files, confirming the completeness of the entry.

Files involved: ibc/testing/app.go, ibc/testing/README.md, app/app.go, app/test_helpers.go
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the completeness and accuracy of state machine breaking changes.

# Test: Check the repository for related documentation and tests.
grep -r "state machine breaking" src/
Length of output: 77

Script:
#!/bin/bash
# Search for the term 'TestingApp' in the repository to find related changes or documentation.
rg 'TestingApp'
Length of output: 3582
808-808: Verify completeness and accuracy of entries.

Please ensure that all state machine breaking changes listed in the v12.1.6 release are documented completely and accurately. This is crucial for users upgrading to this version.

Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>

coderabbitai

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (4)

CHANGELOG.md (4)

95-95: Consider breaking long lines for better readability.

This line exceeds the typical length limit for markdown files, which can affect readability and maintainability. Consider breaking it into multiple lines.

363-363: Consider breaking long lines for better readability.

This line exceeds the typical length limit for markdown files, which can affect readability and maintainability. Consider breaking it into multiple lines.

660-660: Consider breaking long lines for better readability.

This line exceeds the typical length limit for markdown files, which can affect readability and maintainability. Consider breaking it into multiple lines.

Tools

Markdownlint

660-660: Expected: 120; Actual: 230
Line length

(MD013, line-length)

1090-1090: Remove Excessive Blank Lines

Multiple consecutive blank lines found at the end of the file. It's best to keep only one blank line.

Tools

Markdownlint

1090-1090: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fbabf9b and a3dd0a8.

Files selected for processing (1)

CHANGELOG.md (13 hunks)

Additional context used

Markdownlint

CHANGELOG.md

96-96: Expected: 120; Actual: 128
Line length

(MD013, line-length)

392-392: Expected: 120; Actual: 151
Line length

(MD013, line-length)

660-660: Expected: 120; Actual: 230
Line length

(MD013, line-length)

1090-1090: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

CHANGELOG.md

Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>

…evmos/evmos into stepit/sdk50-main-fix-conflicts

0xstepit

This is great @GAtom22 !!!

app/ante/cosmos/eip712.go

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a3dd0a8 and f227fea.

Files ignored due to path filters (1)

go.sum is excluded by !**/*.sum

Files selected for processing (1)

Dockerfile (2 hunks)

Files skipped from review as they are similar to previous changes (1)

Dockerfile

* remove no-op module from begin/end blocker * fix order * remove deprecated encoding * update order genesis * add ibc and vesting to init genesis * remove no op initgenesis on vesting * remove unused methods in consensuswarn ci * fix * re-apply changes --------- Co-authored-by: tom <tomasguerraalda@hotmail.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>

app/app.go

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f227fea and d53f88f.

Files selected for processing (1)

.github/workflows/consensuswarn.yml (1 hunks)

Files skipped from review as they are similar to previous changes (1)

.github/workflows/consensuswarn.yml

GAtom22 added 30 commits November 8, 2023 20:22

wip - bump sdk to v0.50

f59ead2

update chlog

209baf5

fix Dec imports and tests NewContext

7751389

address more issues

70a137b

refactor deliverTx abci method

dd67bfb

replace cometbft-db dep

1de39e0

replace AccountI imports and context in Keepers interface

b49d11d

update keeper instantiation and interfaces

b3e4cd7

update more keepers interfaces

a2274b0

fix keepers and modules interfaces

8120a78

fix more issues

26ff270

fix more issues

8159b8b

fix more issues on return signatures

2b0b340

refactor api server start func

a24faf4

refactor rosetta config

8145a44

refactor rosetta start func

89c8157

fix more issues

5f83e87

fix more issues

fce6d24

fix more issues

3182cad

update proto

dace254

fix migration proto types

d3b3291

fix more issues

2cd6917

update ibc v8

2dbd974

fix more issues

45f9a05

add getMsgsV2 to msgEthTx

024cde0

fix signByAddress calls

eb18ee1

remove deprecated Handlers

8ef17af

refactor BeginBlock and EndBlock in modules

0de9ff4

fix context type issues

5dd6627

fix testutil network setup

7ab7a06

GAtom22 had a problem deploying to release September 5, 2024 17:31 — with GitHub Actions Failure

fix dyn prec test

fbabf9b

GAtom22 had a problem deploying to release September 5, 2024 17:41 — with GitHub Actions Failure

coderabbitai bot reviewed Sep 5, 2024

View reviewed changes

Merge branch 'main' into stepit/sdk50-main-fix-conflicts

a3dd0a8

Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>

GAtom22 had a problem deploying to release September 5, 2024 19:39 — with GitHub Actions Failure

coderabbitai bot reviewed Sep 5, 2024

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

comment out unused storeUpgrades to fix lint warning

71e53fc

GAtom22 had a problem deploying to release September 5, 2024 19:58 — with GitHub Actions Failure

run make format

a29e18d

dev-evmos had a problem deploying to release September 5, 2024 19:59 — with GitHub Actions Failure

Merge branch 'main' into stepit/sdk50-main-fix-conflicts

81a9e91

Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>

GAtom22 temporarily deployed to release September 5, 2024 20:08 — with GitHub Actions Inactive

GAtom22 added 2 commits September 5, 2024 18:46

add evm account query

fb62c1b

Merge branch 'stepit/sdk50-main-fix-conflicts' of https://github.com/…

d11cad0

…evmos/evmos into stepit/sdk50-main-fix-conflicts

GAtom22 temporarily deployed to release September 5, 2024 21:46 — with GitHub Actions Inactive

run make format

009f1b5

dev-evmos temporarily deployed to release September 5, 2024 21:47 — with GitHub Actions Inactive

Merge branch 'main' into stepit/sdk50-main-fix-conflicts

f227fea

0xstepit temporarily deployed to release September 6, 2024 12:49 — with GitHub Actions Inactive

0xstepit approved these changes Sep 6, 2024

View reviewed changes

app/ante/cosmos/eip712.go Show resolved Hide resolved

coderabbitai bot reviewed Sep 6, 2024

View reviewed changes

GAtom22 temporarily deployed to release September 6, 2024 13:10 — with GitHub Actions Inactive

github-actions bot reviewed Sep 6, 2024

View reviewed changes

app/app.go Show resolved Hide resolved

coderabbitai bot reviewed Sep 6, 2024

View reviewed changes

GAtom22 merged commit 4abf423 into main Sep 6, 2024
51 of 55 checks passed

GAtom22 deleted the stepit/sdk50-main-fix-conflicts branch September 6, 2024 13:58

ramacarlucho restored the stepit/sdk50-main-fix-conflicts branch September 6, 2024 14:44

0xstepit deleted the stepit/sdk50-main-fix-conflicts branch December 3, 2024 07:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(deps): bump sdk to v0.50 & IBC to v8 #2771

chore(deps): bump sdk to v0.50 & IBC to v8 #2771

Uh oh!

GAtom22 commented Aug 19, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

0xstepit left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

chore(deps): bump sdk to v0.50 & IBC to v8 #2771

chore(deps): bump sdk to v0.50 & IBC to v8 #2771

Uh oh!

Conversation

GAtom22 commented Aug 19, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0xstepit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GAtom22 commented Aug 19, 2024 •

edited by coderabbitai bot

Loading