Skip to content

chore: add goreleaser version #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 15, 2024
Merged

chore: add goreleaser version #2758

merged 6 commits into from
Aug 15, 2024

Conversation

0xstepit
Copy link
Contributor

@0xstepit 0xstepit commented Aug 13, 2024 •
edited
Loading

Description

Add version to goreleaser to stop printing warnings.

If you have goreleaser installed locally you can check with goreleaser check.

Summary by CodeRabbit

  • Chores
    • Updated the .gitignore file to exclude the dist/ directory from version control.
    • Revised the .goreleaser.yml configuration, upgrading the version to 2 and standardizing string formatting across various entries.
    • Made minor whitespace adjustments for improved readability in the .goreleaser.yml file.
    • Corrected a typographical error in the Makefile related to the release-dry-run target, though the change may lead to command execution issues.

@0xstepit 0xstepit requested a review from a team as a code owner August 13, 2024 16:33
@0xstepit 0xstepit requested review from Vvaradinov and ramacarlucho and removed request for a team August 13, 2024 16:33
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 13, 2024 •
edited
Loading

Walkthrough

The recent changes involve updates to the project configuration and build settings, enhancing standardization and clarity. Key modifications include the addition of the dist/ directory to the .gitignore file to exclude distribution builds from version control, updates to the .goreleaser.yml for versioning and string formatting, and a correction to the Docker command in the Makefile. These changes aim to improve the development workflow and maintain a cleaner project structure.

Changes

Files Change Summary
.gitignore Added dist/ directory to ignore list to exclude distribution builds from version control.
.goreleaser.yml Updated version to 2, standardized name_template quotes from single to double, and revised exclude patterns in changelog for consistency.
Makefile Corrected the working directory option from -w /go/src/$(PACKAGE_NAME) to -we/go/src/$(PACKAGE_NAME), though the new flag appears incorrect.

Poem

In the meadow, changes bloom,
With files refined, dispelling gloom.
A dist/ path now sits in shade,
As builds take flight, unafraid.
Configuration sings in double quotes,
While Docker hops on, taking notes! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the build label Aug 13, 2024
@0xstepit 0xstepit marked this pull request as draft August 13, 2024 16:36
coderabbitai[bot]
coderabbitai bot reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 58eb67e and 3d5fbbe.

Files selected for processing (3)
  • .gitignore (1 hunks)
  • .goreleaser.yml (3 hunks)
  • Makefile (1 hunks)
Files skipped from review due to trivial changes (1)
  • .gitignore
Additional comments not posted (4)
.goreleaser.yml (4)

85-85: LGTM! Consistent string formatting.

The change to double quotes for name_template enhances consistency and should not affect functionality.

97-97: LGTM! Consistent string formatting.

The change to double quotes for name_template enhances consistency and should not affect functionality.

102-103: LGTM! Consistent string formatting.

The change to double quotes for exclude patterns in the changelog section enhances consistency and should not affect functionality.

1-1: Verify the impact of version change to 2.

The change to version: 2 may imply an upgrade in the configuration format or functionality. Ensure compatibility with your current setup.

@0xstepit 0xstepit marked this pull request as ready for review August 13, 2024 16:50
GAtom22
GAtom22 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @0xstepit!!

@0xstepit 0xstepit enabled auto-merge (squash) August 14, 2024 06:41
@0xstepit 0xstepit merged commit e8d9f02 into main Aug 15, 2024
46 of 49 checks passed
@0xstepit 0xstepit deleted the stepit/go-release branch August 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Vvaradinov Vvaradinov Awaiting requested review from Vvaradinov Vvaradinov is a code owner automatically assigned from evmos/core-engineering

+2 more reviewers

@ramacarlucho ramacarlucho ramacarlucho approved these changes

@GAtom22 GAtom22 GAtom22 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xstepit @ramacarlucho @GAtom22