Skip to content

fix(precompiles): update secp256r1 precompile bech32 addr #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2024
Merged

fix(precompiles): update secp256r1 precompile bech32 addr #2550

merged 4 commits into from
May 8, 2024

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented May 8, 2024

Description

This PR updates the bech32 encoding of the secp256r1 curve precompile address to its corresponding value

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@GAtom22 GAtom22 changed the title fix(precompiles): update default precompiles bech32 addr fix(precompiles): update secp256r1 precompile bech32 addr May 8, 2024
@GAtom22 GAtom22 marked this pull request as ready for review May 8, 2024 13:11
@GAtom22 GAtom22 requested a review from a team as a code owner May 8, 2024 13:11
@GAtom22 GAtom22 requested review from Vvaradinov and MalteHerrmann and removed request for a team May 8, 2024 13:11
@GAtom22 GAtom22 merged commit 63ce14b into main May 8, 2024
@GAtom22 GAtom22 deleted the GAtom22/fix-precompile-addr branch May 8, 2024 13:24
facs95 pushed a commit that referenced this pull request May 29, 2024
@GAtom22 @facs95
fix(precompiles): update secp256r1 precompile bech32 addr (#2550)
7d66419 
* fix(precompiles): update default precompiles bech32 addr

* add changelog entry
GAtom22 added a commit that referenced this pull request May 29, 2024
@facs95 @GAtom22
fix(precompiles): update secp256r1 precompile bech32 addr (#2550) (#2586
8686f5d 
)

* fix(precompiles): update default precompiles bech32 addr

* add changelog entry

Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
@MalteHerrmann MalteHerrmann mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

3 more reviewers

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@ramacarlucho ramacarlucho ramacarlucho approved these changes

@0xstepit 0xstepit 0xstepit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
precompile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GAtom22 @Vvaradinov @ramacarlucho @0xstepit