Skip to content

Conversation

0xstepit
Copy link
Contributor

@0xstepit 0xstepit commented Feb 29, 2024

Description

This PR:

  • remove EVM hooks files.
  • Update EVM tests removing tests cases for different hooks.
  • Remove EVM hooks wirings from app.go.
  • Remove logic to handle post tx in evm state transition.

Closes: ENG-2359

Test

Run tests for the evm module:

go test ./x/evm/... -v

Important

EVM hooks are still referenced in the erc20 module.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@github-actions github-actions bot added the tests label Feb 29, 2024
Copy link

linear bot commented Feb 29, 2024

@0xstepit 0xstepit marked this pull request as ready for review February 29, 2024 17:31
@0xstepit 0xstepit requested a review from a team as a code owner February 29, 2024 17:31
@0xstepit 0xstepit requested review from Vvaradinov and ramacarlucho and removed request for a team February 29, 2024 17:31
@GAtom22
Copy link
Contributor

GAtom22 commented Feb 29, 2024

Great work @0xstepit!!

However, I see some tests failing

Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending failing tests

@0xstepit 0xstepit marked this pull request as draft March 1, 2024 15:36
@0xstepit 0xstepit marked this pull request as ready for review March 1, 2024 15:36
@fedekunze fedekunze enabled auto-merge (squash) March 1, 2024 16:02
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @0xstepit !

@fedekunze fedekunze merged commit 07a8a4e into main Mar 1, 2024
@fedekunze fedekunze deleted the stepit/remove-evm-hooks branch March 1, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants