Skip to content

chore(erc20): Remove CLI logic for coin conversion and registration #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2023
Merged

chore(erc20): Remove CLI logic for coin conversion and registration #2155

merged 4 commits into from
Dec 7, 2023

Conversation

Vvaradinov
Copy link
Contributor

Description

Closes ENG-2372

@Vvaradinov Vvaradinov requested a review from a team as a code owner December 7, 2023 08:41
@Vvaradinov Vvaradinov requested review from facs95 and MalteHerrmann and removed request for a team December 7, 2023 08:41
@linear Linear
Copy link

linear bot commented Dec 7, 2023

ENG-2372 Remove CLI Logic for Coin Conversion and Registration

MalteHerrmann
MalteHerrmann approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for nix tests failing

fedekunze
fedekunze reviewed Dec 7, 2023
View reviewed changes
@fedekunze fedekunze merged commit 85b37e3 into main Dec 7, 2023
@fedekunze fedekunze deleted the Vvaradinov/remove-coin-conversion-cli branch December 7, 2023 09:54
@ramacarlucho ramacarlucho mentioned this pull request Apr 23, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@facs95 facs95 Awaiting requested review from facs95 facs95 is a code owner automatically assigned from evmos/core-engineering

+1 more reviewer

@MalteHerrmann MalteHerrmann MalteHerrmann approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vvaradinov @fedekunze @MalteHerrmann