fix(revenue): fixed the problem that users send transactions with gasPrice of 0 to precompiled contracts always failed #2032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith gasPrice of 0 to precompiled contracts
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
+ Coverage 70.39% 70.54% +0.14%
==========================================
Files 338 335 -3
Lines 25223 25091 -132
==========================================
- Hits 17756 17700 -56
+ Misses 6558 6485 -73
+ Partials 909 906 -3
|
|
@fedekunze Could you please help me review the code? Merge as soon as possible if is reasonable. Because I am used to sending transactions with a gasprice of 0 so that I can easily check the flow of native token. |
fedekunze
reviewed
Nov 13, 2023
fedekunze
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I mentioned in the TODO of #2030 that "I have noticed that sending a transaction with gas price set to 0 to invoke a precompiled contract always fails. This might be a bug in all precompiled contracts."，I fixed this issue.
Steps:
First, setting baseFee and minGasPrice in freemarker module are both 0
Then send a transaction with a gasPrice of 0, such as calling the delegate function in the precompiled contract Staking.
Note: the gasPrice in the transaction below is 0x0
{ "jsonrpc":"2.0", "id":127402646348373, "method":"eth_sendTransaction", "params":[ { "gas":"0x1406f40", "gasPrice":"0x0", "from":"0x00000be6819f41400225702d32d3dd23663dd690", "value":"0x0", "data":"0x53266bbb00000000000000000000000000000be6819f41400225702d32d3dd23663dd69000000000000000000000000000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000003365766d6f7376616c6f7065723168616a68367268686b6a716b7765743677716c64336c67783875723479336b686c6a6678383200000000000000000000000000", "to":"0x0000000000000000000000000000000000000800" } ] }The problem will recur!